Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't call notify function without type argument #6767

Closed
nidebo opened this issue Nov 10, 2021 · 3 comments · Fixed by #6768
Closed

Can't call notify function without type argument #6767

nidebo opened this issue Nov 10, 2021 · 3 comments · Fixed by #6768
Labels
bug

Comments

@nidebo
Copy link

nidebo commented Nov 10, 2021

What you were expecting:
Be able to not pass optional argument type to useNotify returned function

What happened instead:
Code breaks because destructuring undefined throws an error.

Steps to reproduce:

const notify = useNotify();
notify();

Environment

  • React-admin version: 3.19.0 and I think will happen on 3.19.1 too.
@WiXSL
Copy link
Contributor

WiXSL commented Nov 10, 2021

Yes, It's been fixed in #6713.

@nidebo
Copy link
Author

nidebo commented Nov 10, 2021

@WiXSL #6760 brought the problem back

@nidebo
Copy link
Author

nidebo commented Nov 10, 2021

opened #6768

@djhi djhi added the bug label Nov 15, 2021
@djhi djhi mentioned this issue Nov 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix notify function when no type is passed nidebo/react-admin
3 participants
@djhi @nidebo @WiXSL