-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs]: Improve buttons sanitation explanation. #4621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This conflicts with #4544 (already in master). Let me merge |
Done, please rebase |
79eef9c
to
7b12716
Compare
Done. |
I don't understand, the previous code snippet already took care of sanitizing the extra props. |
Since we fixed the CreateButton props sanitation, and this Create and Edit views documentation already have a lot of tips and examples, I'm in favor of removing this tip. Also, this is an example of heavy customation, and the Create / Edit views documentation isn't really the good place for that. We have plenty of examples of customation on the demo IMHO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second read, this is correct, thanks for the explanation and sorry for the questions. Can you just cancel the white space changes in the rest of the file?
They are not white spaces, they are zero width unicode characters (in this case \u200B). Please confirm about this. |
You're right! How did you detect those? Some of us may have a bad setting in their IDE. |
I'm using a plugin for IntelliJ-based IDEs. https://plugins.jetbrains.com/plugin/7448-zero-width-characters-locator |
Nice. I found this equivalent plugin for VSCode: https://marketplace.visualstudio.com/items?itemName=nhoizey.gremlins |
Oh, I'll take note of that. Thanks. |
Because of #4574