Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Improve buttons props sanitation #4574

Merged
merged 21 commits into from
Mar 30, 2020
Merged

[RFR] Improve buttons props sanitation #4574

merged 21 commits into from
Mar 30, 2020

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Mar 24, 2020 •
edited
Loading

@WiXSL WiXSL changed the title Improve buttons props sanitation [RFR] Improve buttons props sanitation Mar 24, 2020
@WiXSL WiXSL changed the title [RFR] Improve buttons props sanitation [WIP] Improve buttons props sanitation Mar 28, 2020
@WiXSL WiXSL changed the title [WIP] Improve buttons props sanitation [RFR] Improve buttons props sanitation Mar 28, 2020
@WiXSL WiXSL force-pushed the improve-buttons-toolbar-props-sanitation branch from 5906d5d to 2696b52 Compare March 28, 2020 22:00
fzaninotto
fzaninotto requested changes Mar 29, 2020
View reviewed changes
packages/ra-ui-materialui/src/button/BulkExportButton.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/button/BulkDeleteWithConfirmButton.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/button/DeleteWithConfirmButton.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/button/DeleteWithConfirmButton.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/button/DeleteWithUndoButton.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/button/ExportButton.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/button/SaveButton.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/layout/Confirm.tsx Outdated Show resolved Hide resolved
@WiXSL WiXSL requested a review from fzaninotto March 29, 2020 20:56
@WiXSL
Copy link
Contributor Author

WiXSL commented Mar 29, 2020 •
edited
Loading

@fzaninotto, now it's ready for review.

@fzaninotto fzaninotto merged commit 48f5dcb into marmelab:next Mar 30, 2020
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 3.4.0 milestone Mar 30, 2020
@WiXSL WiXSL deleted the improve-buttons-toolbar-props-sanitation branch March 31, 2020 13:09
This was referenced Mar 31, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@WiXSL @fzaninotto