Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mapillary infinite loop and improve ui #2455

Merged
merged 11 commits into from
Jan 8, 2025

remove useEffect

bca302f
Select commit
Loading
Failed to load commit list.
Merged

fix mapillary infinite loop and improve ui #2455

remove useEffect
bca302f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Jan 8, 2025 in 1s

57.59% of diff hit (target 56.82%)

View this Pull Request on Codecov

57.59% of diff hit (target 56.82%)

Annotations

Check warning on line 69 in src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx#L69 

Added line #L69 was not covered by tests

Check warning on line 72 in src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx#L71-L72 

Added lines #L71 - L72 were not covered by tests

Check warning on line 74 in src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx#L74 

Added line #L74 was not covered by tests

Check warning on line 81 in src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx#L76-L81 

Added lines #L76 - L81 were not covered by tests

Check warning on line 84 in src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx#L83-L84 

Added lines #L83 - L84 were not covered by tests

Check warning on line 88 in src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx#L86-L88 

Added lines #L86 - L88 were not covered by tests

Check warning on line 91 in src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx#L91 

Added line #L91 was not covered by tests

Check warning on line 103 in src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx#L102-L103 

Added lines #L102 - L103 were not covered by tests

Check warning on line 110 in src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx#L108-L110 

Added lines #L108 - L110 were not covered by tests

Check warning on line 115 in src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx#L113-L115 

Added lines #L113 - L115 were not covered by tests

Check warning on line 143 in src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx#L142-L143 

Added lines #L142 - L143 were not covered by tests

Check warning on line 147 in src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx#L145-L147 

Added lines #L145 - L147 were not covered by tests

Check warning on line 151 in src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx#L149-L151 

Added lines #L149 - L151 were not covered by tests

Check warning on line 160 in src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/EnhancedMap/ImageMarkerLayer/ImageMarkerLayer.jsx#L160 

Added line #L160 was not covered by tests

Check warning on line 74 in src/components/TaskPane/TaskMap/TaskMap.jsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/TaskPane/TaskMap/TaskMap.jsx#L74 

Added line #L74 was not covered by tests

Check warning on line 116 in src/components/TaskPane/TaskMap/TaskMap.jsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/TaskPane/TaskMap/TaskMap.jsx#L115-L116 

Added lines #L115 - L116 were not covered by tests

Check warning on line 123 in src/components/TaskPane/TaskMap/TaskMap.jsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/TaskPane/TaskMap/TaskMap.jsx#L120-L123 

Added lines #L120 - L123 were not covered by tests

Check warning on line 127 in src/components/TaskPane/TaskMap/TaskMap.jsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/TaskPane/TaskMap/TaskMap.jsx#L126-L127 

Added lines #L126 - L127 were not covered by tests

Check warning on line 142 in src/components/TaskPane/TaskMap/TaskMap.jsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/TaskPane/TaskMap/TaskMap.jsx#L137-L142 

Added lines #L137 - L142 were not covered by tests

Check warning on line 146 in src/components/TaskPane/TaskMap/TaskMap.jsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/TaskPane/TaskMap/TaskMap.jsx#L144-L146 

Added lines #L144 - L146 were not covered by tests

Check warning on line 256 in src/components/TaskPane/TaskMap/TaskMap.jsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/TaskPane/TaskMap/TaskMap.jsx#L254-L256 

Added lines #L254 - L256 were not covered by tests

Check warning on line 260 in src/components/TaskPane/TaskMap/TaskMap.jsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/TaskPane/TaskMap/TaskMap.jsx#L258-L260 

Added lines #L258 - L260 were not covered by tests

Check warning on line 275 in src/components/TaskPane/TaskMap/TaskMap.jsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/TaskPane/TaskMap/TaskMap.jsx#L262-L275 

Added lines #L262 - L275 were not covered by tests

Check warning on line 291 in src/components/TaskPane/TaskMap/TaskMap.jsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/TaskPane/TaskMap/TaskMap.jsx#L291 

Added line #L291 was not covered by tests

Check warning on line 303 in src/components/TaskPane/TaskMap/TaskMap.jsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/TaskPane/TaskMap/TaskMap.jsx#L298-L303 

Added lines #L298 - L303 were not covered by tests
View more details on Codecov