Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mapillary infinite loop and improve ui #2455

Merged
merged 11 commits into from
Jan 8, 2025

Conversation

CollinBeczak
Copy link
Collaborator

@CollinBeczak CollinBeczak commented Sep 30, 2024

Resolves: #2444
Fix Mapillary bug, when the popup is at the edge of the map, an infinite loop occurred.
Screenshot 2024-09-30 at 4 02 08 PM
Screenshot 2024-09-30 at 4 02 17 PM
Screenshot 2024-09-30 at 4 02 30 PM

@CollinBeczak CollinBeczak marked this pull request as ready for review October 9, 2024 00:32
@CollinBeczak CollinBeczak force-pushed the CollinBeczak/EnhanceTaskMap branch from 06573bb to 3bae67a Compare November 10, 2024 17:44
jake-low
jake-low previously approved these changes Dec 10, 2024
Copy link
Contributor

@jake-low jake-low left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a small bug while reviewing but once that's fixed this looks good to me.

jake-low
jake-low previously approved these changes Jan 7, 2025
Copy link
Contributor

@jake-low jake-low left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CollinBeczak CollinBeczak merged commit 341ad47 into main Jan 8, 2025
6 checks passed
@CollinBeczak CollinBeczak deleted the CollinBeczak/EnhanceTaskMap branch January 8, 2025 15:30
@CollinBeczak CollinBeczak mentioned this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mapillary Viewer is broken
2 participants