This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Deprecate style methods #7776
Closed
Deprecate style methods #7776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boundsj
suggested changes
Jan 18, 2017
| @@ -370,14 +370,14 @@ static const NSInteger MGLStyleDefaultVersion = 9; | |||
| @param styleClass The style class to query for. | |||
| @return Whether the style class is currently active. | |||
| */ | |||
| - (BOOL)hasStyleClass:(NSString *)styleClass; | |||
| - (BOOL)hasStyleClass:(NSString *)styleClass __attribute__((deprecated("This method will be removed in a future release. Runtime styling is :sunglasses:"))); | |||
There was a problem hiding this comment.
We should remove the reference to runtime styling and 😎 here
👍 we can point this to the release-ios-v3.4.1 branch when it is created |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #7577 and #2875 we should mark style methods and properties as deprecated because we will not support them on future releases.
The Android SDK has already deprecated same API.
This is a temporarily PR to branch release-ios-v3.4.0, this should be included in release-ios-v3.4.1