This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Remove style class support #2875
Labels
Core
The cross-platform C++ core, aka mbgl
Comments
Nope, Node doesn't use these APIs. |
This was referenced Jan 11, 2016
This will be picked up transitioning API from MapView to MapboxMap with #3145. |
Let's hold on removing any features around this. The final status of style classes has not been decided yet. |
I removed the public java API since it was crashing, the jni code is still there. |
@tobrun can we remove the Android label from this ticket? |
Don't think this is relevant anymore. Closing |
This was referenced Jan 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It is time to mark the style class APIs as deprecated in iOS and Android.
Mapbox Studio does not support creating styles with classes in them. None of the bundled styles uses them. Neither the iOS nor Android test apps/Sirius touch these APIs.
As far as I know they could be completely broken and we would not even notice.
We should first update the documentation to mark them as deprecated.
Eventually we can remove them entirely.
This does not require any changes to core GL at this stage. Basically will only affect the higher level OS specific wrappers.
This will allow us to close:
#794
#1744
#2077
@mikemorris Does node still need to support style classes?
@1ec5 Are there any open iOS tickets this will close?
The text was updated successfully, but these errors were encountered: