Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Remove style class support #2875

Closed
ljbade opened this issue Oct 30, 2015 · 6 comments
Closed

Remove style class support #2875

ljbade opened this issue Oct 30, 2015 · 6 comments
Labels
Core The cross-platform C++ core, aka mbgl

Comments

@ljbade
Copy link
Contributor

ljbade commented Oct 30, 2015

It is time to mark the style class APIs as deprecated in iOS and Android.

Mapbox Studio does not support creating styles with classes in them. None of the bundled styles uses them. Neither the iOS nor Android test apps/Sirius touch these APIs.

As far as I know they could be completely broken and we would not even notice.

We should first update the documentation to mark them as deprecated.

Eventually we can remove them entirely.

This does not require any changes to core GL at this stage. Basically will only affect the higher level OS specific wrappers.

This will allow us to close:
#794
#1744
#2077

@mikemorris Does node still need to support style classes?

@1ec5 Are there any open iOS tickets this will close?

@ljbade ljbade added iOS Mapbox Maps SDK for iOS Android Mapbox Maps SDK for Android labels Oct 30, 2015
@mikemorris
Copy link
Contributor

Nope, Node doesn't use these APIs.

@tobrun
Copy link
Member

tobrun commented Jan 11, 2016

This will be picked up transitioning API from MapView to MapboxMap with #3145.

tobrun added a commit that referenced this issue Jan 11, 2016
@jfirebaugh
Copy link
Contributor

Let's hold on removing any features around this. The final status of style classes has not been decided yet.

tobrun added a commit that referenced this issue Jan 22, 2016
tobrun added a commit that referenced this issue Jan 25, 2016
@tobrun
Copy link
Member

tobrun commented Mar 6, 2016

I removed the public java API since it was crashing, the jni code is still there.

@cammace
Copy link
Contributor

cammace commented Nov 9, 2016

@tobrun can we remove the Android label from this ticket?

@tobrun
Copy link
Member

tobrun commented Nov 10, 2016

Don't think this is relevant anymore. Closing

@tobrun tobrun closed this as completed Nov 10, 2016
@jfirebaugh jfirebaugh added Core The cross-platform C++ core, aka mbgl and removed Android Mapbox Maps SDK for Android iOS Mapbox Maps SDK for iOS labels Nov 23, 2016
@jfirebaugh jfirebaugh reopened this Nov 23, 2016
@jfirebaugh jfirebaugh changed the title Deprecate style classes in iOS/Android Remove style class support Nov 23, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl
Projects
None yet
Development

No branches or pull requests

5 participants