Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

MapView.setAccessToken() should trim whitespace #2919

Closed
1ec5 opened this issue Nov 3, 2015 · 1 comment
Closed

MapView.setAccessToken() should trim whitespace #2919

1ec5 opened this issue Nov 3, 2015 · 1 comment
Assignees
@bleege
Labels
Android Mapbox Maps SDK for Android
Milestone
android-v2.3.0

Comments

@1ec5
Copy link
Contributor

1ec5 commented Nov 3, 2015

Per #2912, MapView.setAccessToken() should trim whitespace from either end before validating the access token. It doesn’t look like MapView needs to do any style URL validation independently of mbgl, since it traffics in Strings the whole way.

/cc @ljbade
@1ec5 1ec5 added the Android Mapbox Maps SDK for Android label Nov 3, 2015
@bleege bleege added this to the android-v2.3.0 milestone Nov 3, 2015
bleege added a commit that referenced this issue Nov 5, 2015
@bleege
[android] #2919 - Trimming whitespace during setAccessToken()
b8e8d96
@bleege bleege self-assigned this Nov 5, 2015
@bleege bleege mentioned this issue Nov 5, 2015
Closed
bleege added a commit that referenced this issue Nov 5, 2015
@bleege
[android] #2919 - Trimming whitespace during setAccessToken()
c8de6fd
@bleege
Copy link
Contributor

bleege commented Nov 5, 2015

Rebased, discussed the finer points of Java Annotations with @1ec5, and merged.

@bleege bleege closed this as completed Nov 5, 2015
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
@bleege
[android] mapbox#2919 - Trimming whitespace during setAccessToken()
cf602cb
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bleege bleege

Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
android-v2.3.0
Development

No branches or pull requests
3 participants
@mourner @bleege @1ec5