Trimming Whitespace In setAccessToken() #2950

bleege · 2015-11-05T23:00:18Z

1ec5 · 2015-11-05T23:01:48Z

android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/views/MapView.java

@@ -1563,6 +1563,9 @@ private void validateAccessToken(String accessToken) {
    @UiThread
    public void setAccessToken(@NonNull String accessToken) {
        // validateAccessToken does the null check
+        if (!TextUtils.isEmpty(accessToken)) {
+            accessToken = accessToken.trim();


To catch all-whitespace tokens, trim first then ask questions later.

Gotta do a Null check first (which is what TextUtils.isEmpty() is doing). If not when a null shows up the trim will crash things.

bleege · 2015-11-05T23:33:24Z

Rebased and merged.

[android] #2919 - Trimming whitespace during setAccessToken()

b8e8d96

bleege added the Android Mapbox Maps SDK for Android label Nov 5, 2015

bleege added this to the android-v2.3.0 milestone Nov 5, 2015

mourner added the in progress label Nov 5, 2015

1ec5 reviewed Nov 5, 2015
View reviewed changes

bleege closed this Nov 5, 2015

mourner removed the in progress label Nov 5, 2015

bleege deleted the 2919-trim-the-access-token branch November 5, 2015 23:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Trimming Whitespace In setAccessToken() #2950

Trimming Whitespace In setAccessToken() #2950

bleege commented Nov 5, 2015

1ec5 Nov 5, 2015

bleege Nov 5, 2015

bleege commented Nov 5, 2015

Trimming Whitespace In setAccessToken() #2950

Trimming Whitespace In setAccessToken() #2950

Conversation

bleege commented Nov 5, 2015

1ec5 Nov 5, 2015

Choose a reason for hiding this comment

bleege Nov 5, 2015

Choose a reason for hiding this comment

bleege commented Nov 5, 2015