[release-danube] Release blockers #9529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add regression test for #9518 * More thorough input checks for isPatternMissing function Fixes regression introduced by #9380 ResolvedImage.fromString may now return null, which potentially leaves CrossFaded<ResolvedImage> with missing image patterns I have traced other code paths using ResolvedImage.fromString and have not seen any other potential offenders
* - Add a build-time check for style-spec referencing external files - Refactor within to NOT import external files * Address review comments (cherry picked from commit 2b898c9)
|
Added #9521 |
arindam1993
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of release blockers for 1.10.0, 3de1b9f, 2ed1e13. Blocked until #9521.
Relates to issues #9518, #9524 and #9519.