Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@mapbox/mapbox-gl-style-spec references unbundled modules => build-time error #9524

Closed
elifitch opened this issue Apr 9, 2020 · 0 comments
Closed

Comments

@elifitch
Copy link
Contributor

elifitch commented Apr 9, 2020

When referencing modules that are not explicitly exported in /dist, as Studio does here and there to enable advanced features, I get a build-time error.

image

It looks like within.js is in fact referencing a data constant that is not bundled with the style spec package itself. https://github.com/mapbox/mapbox-gl-js/blob/master/src/style-spec/expression/definitions/within.js#L11

mapbox-gl-js version: 1.9.1

browser: N/A

Steps to Trigger Behavior

  1. Import @mapbox/mapbox-gl-style-spec.
  2. Attempt to reference the within expression definition.

Link to Demonstration

Creating an online example of this was difficult, but Mapbox Studio is a current one. Happy to work with y'all on replicating this behavior.

Expected Behavior

Possible to import modules from the src directory of @mapbox/mapbox-gl-style-spec.

Actual Behavior

Importing modules from the src directory of @mapbox/mapbox-gl-style-spec references files that are not bundled with the package.


Posting here and tagging as release-blocker per advice from @arindam1993 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants