fix writing to memory #497
Conversation
| @@ -199,7 +199,7 @@ defmodule EVM.MessageCall do | |||
| %{machine_state | last_return_data: output} | |||
|
|
|||
| true -> | |||
| machine_state = Memory.write(machine_state, out_offset, output) | |||
| machine_state = Memory.write(machine_state, out_offset, output, out_size) | |||
There was a problem hiding this comment.
Is there a test that we could add for this? It seems like this was an important piece that was overlooked, and in terms of making sure we don't re-introduce this bug in the future, it would be nice to have a test that covers this. What do you think?
| machine_state = %MachineState{} | ||
| updated_machine_state = Memory.write(machine_state, 256, <<>>, 0) | ||
| assert machine_state == updated_machine_state | ||
| describe "write/4" do |
| |> :binary.encode_unsigned() | ||
| else | ||
| original_data | ||
| cond do |
There was a problem hiding this comment.
This is more clear what's going on here too 👍
| "stRevertTest/RevertOpcodeMultipleSubCalls", | ||
| "stSpecialTest/failed_tx_xcf416c53" | ||
| ], | ||
| "TangerineWhistle" => ["stRevertTest/RevertOpcodeMultipleSubCalls"] |
There was a problem hiding this comment.
Yes! Opcode multiple subcalls 🔥
|
|
||
| account_interface = | ||
| build(:mock_account_interface) | ||
| |> MockAccountInterface.add_account(recipient.address, %{balance: 10, code: recipient.code}) |
There was a problem hiding this comment.
Is the AcountInterface stuff still in? Did I fail to remove it?
| byte_value = | ||
| value | ||
| |> rem(8 * EVM.word_size()) | ||
| |> :binary.encode_unsigned() |
There was a problem hiding this comment.
This was added since the last time I reviewed this. Just curious, did this fix more things?
There was a problem hiding this comment.
@germsvel this logic was moved from Memory.write. It's needed for getting one byte from value
| @@ -129,13 +129,13 @@ Ethereum common tests are created for all clients to test against. We plan to pr | |||
| - [GeneralStateTests](https://github.com/ethereum/tests/tree/develop/GeneralStateTests) 1026/1026 = 100% passing | |||
| - [x] Homestead | |||
| - [BlockchainTests](https://github.com/ethereum/tests/tree/develop/BlockchainTests) (Includes GeneralStateTests) 2231/2231 = 100% passing | |||
| - [GeneralStateTests](https://github.com/ethereum/tests/tree/develop/GeneralStateTests) 2059/2061 = 99.9% passing | |||
| - [GeneralStateTests](https://github.com/ethereum/tests/tree/develop/GeneralStateTests) 2061/2061 = 100.0% passing | |||
9fcfa14 to
cc89ba6
Compare
fixes #491
Changes:
out_sizeparameter when we were writing to the memory after message call. If it is smaller than output's size than we should truncate outputMemorymodule was wrong