Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for truncated output in EVM subcalls #558

Closed
ayrat555 opened this issue Nov 29, 2018 · 6 comments
Closed

add tests for truncated output in EVM subcalls #558

ayrat555 opened this issue Nov 29, 2018 · 6 comments
Assignees

Comments

@ayrat555
Copy link
Contributor

ayrat555 commented Nov 29, 2018

Our client is passing all common tests for all hardforks but it failed consensus because we didn't truncate subcall outputs when actual output size is bigger than out_size parameter

mana-ethereum/mana#497
mana-ethereum/mana#679

@winsvega
Copy link
Collaborator

this? #567

@ayrat555
Copy link
Contributor Author

@winsvega the problem was in reverted operation output. does your PR test a reverted subcall's output?

@winsvega
Copy link
Collaborator

you mean when a subcall revert return more then subcall return expect?

@winsvega
Copy link
Collaborator

I've updated the test case. could you check that it hits your bug?

@winsvega
Copy link
Collaborator

winsvega commented Mar 1, 2021

@qbzzt check if the issue case is covered

@qbzzt qbzzt self-assigned this Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants