Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generates OBJ file either from multilane or dragway implementation. (#3) #11

Merged
merged 2 commits into from
Apr 6, 2020
Merged

Generates OBJ file either from multilane or dragway implementation. (#3) #11

merged 2 commits into from
Apr 6, 2020

Conversation

francocipollone
Copy link
Collaborator

Solves #3

  • Renames yaml_to_obj.cc to maliput_to_obj.cc.
  • Adds the possibility to generate OBJ file from a dragway road geometry implementation.

agalbachicar
agalbachicar requested changes Apr 3, 2020
View reviewed changes
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits to go.

agalbachicar
agalbachicar approved these changes Apr 6, 2020
View reviewed changes
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit 2c209ad into master Apr 6, 2020
@francocipollone francocipollone deleted the francocipollone/#3_yaml_to_obj_to_maliput_to_obj branch April 6, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalbachicar agalbachicar agalbachicar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francocipollone @agalbachicar