Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Byteswap issues #77

Open
malachib opened this issue Jan 2, 2025 · 0 comments
Open

Byteswap issues #77

malachib opened this issue Jan 2, 2025 · 0 comments
Labels
bug Something isn't working enhancement New feature or request
Milestone
v0.8.3

Comments

@malachib
Copy link
Contributor

malachib commented Jan 2, 2025 •
edited
Loading

Byteswap has issues:

  • 64-bit incorrectly checks against 32-bit support, and silently falls down to returning 0
  • Lacks a signed version

NOTE: Code looks to run OK and mainly just ultra ugly. Classified as a bug anyway since it's that ugly

Also, comparison __cpp_lib_byteswap >= 202110L appears inconsistent in ESP-IDF v5.3.2. Add a force std/force estd feature flag for this. Aggravated in particular by embr::gl who tries to overload some signed flavors

Finally, a non-std and non-gcc fallback would be nice, but not necessary for this ticket
@malachib malachib added bug Something isn't working enhancement New feature or request labels Jan 2, 2025
@malachib malachib added this to the v0.8.3 milestone Jan 2, 2025
malachib added a commit that referenced this issue Jan 3, 2025
@malachib
feat(byteswap): adding signed versions, feature flags
1461b33 
Also refactoring away from specialized approach and paving way for
(currently unimplemented) xor version

#77
malachib added a commit that referenced this issue Jan 3, 2025
@malachib
test(byteswap): successful ESP32C6 testing
531328c 
#77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
v0.8.3
Development

No branches or pull requests
1 participant
@malachib