test(byteswap): successful ESP32C6 testing

#77
malachi-iot · Jan 3, 2025 · 531328c · 531328c
1 parent eea4016
commit 531328c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 16 deletions.
diff --git a/test/rtos/esp32/README.md b/test/rtos/esp32/README.md
@@ -27,7 +27,7 @@ These tests are all for variants of Espressif ESP32
 | 29SEP23 | unity    | ESP32-C3-DevKitM-1   | ESP32C3        | v5.1.1   | Pass   |
 | 19DEC23 | unity    | WaveShare C6-DevKit  | ESP32C6        | v5.1.2   | Pass   |
 | 18NOV23 | unity    | ESP32C3 Xiao         | ESP32C3        | v5.1.2   | Pass   |
-| 09DEC24 | unity    | ESP32C3 Xiao         | ESP32C6        | v5.3.2   | Pass   | Manual indication of USJ required.  test_freertos_clock fails
+| 03JAN24 | unity    | ESP32C6 Xiao         | ESP32C6        | v5.3.2   | Pass   | Manual indication of USJ required.  test_freertos_clock fails
 | 20JUL23 | unity    | ESP32 Lolin Generic  | ESP32          | v5.0.3   | Pass   |
 | 05MAR24 | unity    | ESP-WROVER-KIT v4.1  | ESP32-WROVER-E | v5.1.2   | Pass   |
 | 29SEP23 | unity    | Lilygo QT Pro        | ESP32S3        | v5.1.1   | Pass*  | Intermittent failures[^1]

diff --git a/test/rtos/esp32/unity/components/testable/test/CMakeLists.txt b/test/rtos/esp32/unity/components/testable/test/CMakeLists.txt
@@ -4,18 +4,6 @@
 #                    REQUIRES unity testable)
 
 
-# TODO: If ESTDLIB_DIR below works as expected, we can obsolete this
-set(UNITY_SRCDIR "../../../../../../unity")
-#set(UNITY_SRCDIR "")
-
-# Worringly, this appears twice during build, first time with ESTDLIB_DIR populated
-# and second time not.  However, compilation appears to pick up unity folder -
-# so perhaps we're OK?  Test against ESP32 to be extra sure.  Note also tossing
-# around NO_POLICY_SCOPE appears to make no difference
-message("TESTABLE: UNIT_SRCDIR=${UNITY_SRCDIR} / ${ESTDLIB_DIR} / ${TESTESTD}")
-
-#set(COMPONENT_SRCDIRS "." ${UNITY_SRCDIR})
-#set(COMPONENT_SRCDIRS "." ${ESTDLIB_DIR}/test/unity)
 set(COMPONENT_SRCDIRS ${ESTDLIB_DIR}/test/unity)
 set(COMPONENT_ADD_INCLUDEDIRS ".")
 

diff --git a/test/unity/bit.cpp b/test/unity/bit.cpp
@@ -8,9 +8,9 @@ TEST_CASE("bit/endian tests", "[bit]")
 void test_bit()
 #endif
 {
-    auto vu16 = estd::byteswap<uint16_t>(0x1234);
-    auto vi32 = estd::byteswap<int32_t>(-500);
+    constexpr auto vu16 = estd::byteswap<uint16_t>(0x1234);
+    constexpr auto vi32 = estd::byteswap<int32_t>(-500);
 
-    TEST_ASSERT_EQUAL(0x3421, vu16);
+    TEST_ASSERT_EQUAL(0x3412, vu16);
     TEST_ASSERT_EQUAL(-500, estd::byteswap(vi32));
 }