Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduces Features DSL #8

Merged
merged 22 commits into from
Aug 24, 2023
Merged
Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
f0dda37
chore: makes cleanup functions not part of OssmInstaller struct
bartoszmajsak Aug 8, 2023
1a01122
feat(feature): introduces Features dsl
bartoszmajsak Aug 21, 2023
b100498
chore: cleans up manifests apply logic
bartoszmajsak Aug 22, 2023
d02c430
feat: moves features to its own package
bartoszmajsak Aug 22, 2023
ca2dddd
chore: removes feature_ file prefixes
bartoszmajsak Aug 22, 2023
5b846cc
chore: moves embedded templates to its own file
bartoszmajsak Aug 22, 2023
b550da0
wip: tests
bartoszmajsak Aug 22, 2023
7a587cb
chore: moves test CRDs to feature pkg
bartoszmajsak Aug 22, 2023
8d08e48
fix: creates resource tracker after builder is initialized
bartoszmajsak Aug 22, 2023
6148fbf
feat: adjusts tests to feature approach
bartoszmajsak Aug 22, 2023
d3d4526
chore: logs applied manifest
bartoszmajsak Aug 23, 2023
8f7efb2
chore: allows multiple calls of the same builder funcs
bartoszmajsak Aug 23, 2023
0ea7b3e
chore: removes unused .Spec from Feature struct
bartoszmajsak Aug 23, 2023
3031ce6
chore: renames .ClusterData to .Spec
bartoszmajsak Aug 23, 2023
b6606e2
chore: splits data loading to smaller funcs
bartoszmajsak Aug 23, 2023
be5046e
fix: adds manifests from all paths
bartoszmajsak Aug 23, 2023
eed85ca
chore: renames some builder funcs
bartoszmajsak Aug 23, 2023
f72c5a8
feat: introduces focused integration test for secret volume removal
bartoszmajsak Aug 23, 2023
0867d1d
chore: renames created features
bartoszmajsak Aug 24, 2023
88224c7
fix: tests are using tmp directories for manifests
bartoszmajsak Aug 24, 2023
c574777
chore: exports OAuth struct
bartoszmajsak Aug 24, 2023
5993305
chore: adds tests for external auth provider
bartoszmajsak Aug 24, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions apis/ossm.plugins.kubeflow.org/v1alpha1/ossm_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,15 @@ type OssmResourceTracker struct {
Status OssmResourceTrackerStatus `json:"status,omitempty"`
}

func (o *OssmResourceTracker) ToOwnerReference() metav1.OwnerReference {
return metav1.OwnerReference{
APIVersion: o.APIVersion,
Kind: o.Kind,
Name: o.Name,
UID: o.UID,
}
}

// OssmResourceTrackerSpec defines the desired state of OssmResourceTracker
type OssmResourceTrackerSpec struct {
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ spec:
description: OssmPluginSpec defines the extra data provided by the Openshift
Service Mesh Plugin in KfDef spec.
properties:
appNamespace:
description: Additional non-user facing fields (should not be copied
to the CRD)
type: string
auth:
properties:
authorino:
Expand Down
4 changes: 2 additions & 2 deletions config/manager/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
images:
- name: controller
newName: quay.io/opendatahub/opendatahub-operator
newTag: dev-0.0.1
newName: quay.io/maistra-dev/opendatahub-operator
newTag: dev-0.0.6
2 changes: 1 addition & 1 deletion pkg/kfapp/coordinator/coordinator.go
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ func (kfapp *coordinator) Delete(resources kftypesv3.ResourceEnum) error {
}
} else {
ossmInstaller := p.(*ossm.OssmInstaller)
return ossmInstaller.CleanupOwnedResources()
return ossmInstaller.CleanupResources()
}
}

Expand Down
250 changes: 0 additions & 250 deletions pkg/kfapp/ossm/cleanup.go

This file was deleted.

Loading