feat: introduces Features DSL #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoszmajsak
commented
Aug 23, 2023
- easy builder to define what particular feature consists of
- enables the use of existing YAML manifests
- allows definition of additional resources programmatically with a simple func registration
- cleanup funcs are now part of each feature and are called one after the other
- each feature has its own resource tracker object
- easy builder to define what particular feature consists of - enables use of existing YAML manifests - allows to define additional resources programatically with a simple func registration - cleanup funcs are now part of each feature and are called one after the other - each feature has its own resource tracker object
and fixes tracker naming few TODOs left, will address them in subsequent commits
by appending to corresponding structs instead of overwriting them
cam-garrison
approved these changes
Aug 23, 2023
bartoszmajsak
commented
Aug 24, 2023
pkg/kfapp/ossm/templates/control-plane/base/control-plane-ingress.patch.yaml
Outdated
Show resolved
Hide resolved
bartoszmajsak
added a commit
that referenced
this pull request
Sep 6, 2023
- easy builder to define what particular feature consists of - enables the use of existing YAML manifests - allows the definition of additional resources programmatically with a simple func registration - cleanup functions are now part of each feature and are called one after the other - each feature has its own resource tracker object - ability to test smaller parts of the whole thing by using `Feature`s in integration tests
bartoszmajsak
added a commit
that referenced
this pull request
Sep 6, 2023
- easy builder to define what particular feature consists of - enables the use of existing YAML manifests - allows the definition of additional resources programmatically with a simple func registration - cleanup functions are now part of each feature and are called one after the other - each feature has its own resource tracker object - ability to test smaller parts of the whole thing by using `Feature`s in integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.