Fixing bug with non-existent customer group breaking quote

[kodubovik]

Description (*)

There's a bug when a customer group deleted, it's still referenced in active quotes which causes an error on the checkout page.
Such a quote becomes broken and the customer is not able to place an order. This pull request adds functionality for getting customer group from the current customer in case customer group saved to the quote does not exist.

Manual testing scenarios (*)

1. Create a new customer group.
2. Create a new customer. Link that customer to the customer group created on the previous step.
3. Log in to the Magento storefront and add some products to the shopping cart.
4. Go to the admin and delete the customer group created on step 1.
5. Return to the storefront and proceed to checkout.

• Expected result: a customer should be able to complete an order without any issue.
• Actual result: an error "No such entity id = ... " displayed. Shipping methods are not rendered.
  

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Fixing bug with non-existent customer group breaking quote #29327: Fixing bug with non-existent customer group breaking quote

[m2-assistant]

Hi @kodubovik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[kodubovik]

@magento run all tests

[swnsma]

@magento run all tests

[kodubovik]

@magento run all tests

[swnsma]

@magento run all tests

[magento-engcom-team]

Hi @swnsma, thank you for the review.
ENGCOM-7793 has been created to process this Pull Request
✳️ @swnsma, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Alfa]

Hi @kodubovik

Due to Magento Definition of Done all changes should be covered by automated tests.
Could you please cover your fix by a MFTF test?
Thank you.

[magento-engcom-team]

Hi @swnsma, thank you for the review.
ENGCOM-7793 has been created to process this Pull Request

[engcom-Charlie]

@magento run all tests

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. Create a new customer group;
2. Create a new customer. Link that customer to the customer group created on the previous step.
3. Log in to the Magento storefront and add some products to the shopping cart.
4. Go to the admin and delete the customer group created on step 1.
5. Return to the storefront and proceed to checkout.

Before: ✖️ an error "No such entity id = ... " displayed. Shipping methods are not rendered.

After: ✔️ Shipping methods are rendered and the order was successfully created with the default customer group

[engcom-Alfa]

@magento create issue

[engcom-Charlie]

@magento run all tests

[swnsma]

@magento run all tests

[engcom-Charlie]

@magento run all tests

[m2-assistant]

Hi @kodubovik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.