Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Fixing bug with non-existent customer group breaking quote #29327

Closed
3 of 4 tasks
m2-assistant bot opened this issue Jul 30, 2020 · 2 comments · Fixed by #28902
Closed
3 of 4 tasks

[Issue] Fixing bug with non-existent customer group breaking quote #29327

m2-assistant bot opened this issue Jul 30, 2020 · 2 comments · Fixed by #28902
Assignees
@kodubovik
Labels
Component: Checkout Component: Quote Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers

Comments

@m2-assistant
Copy link

m2-assistant bot commented Jul 30, 2020 •
edited by engcom-Alfa
Loading

This issue is automatically created based on existing pull request: #28902: Fixing bug with non-existent customer group breaking quote

Preconditions (*)

There's a bug when a customer group deleted, it's still referenced in active quotes which causes an error on the checkout page.
Such a quote becomes broken and the customer is not able to place an order. This pull request adds functionality for getting customer group from the current customer in case customer group saved to the quote does not exist.

Steps to reproduce (*)

  1. Create a new customer group.
  2. Create a new customer. Link that customer to the customer group created on the previous step.
  3. Log in to the Magento storefront and add some products to the shopping cart.
  4. Go to the admin and delete the customer group created on step 1.
  5. Return to the storefront and proceed to checkout.

Actual result: ✖️ an error "No such entity id = ... " displayed. Shipping methods are not rendered.
missin_customer_group

Expected result: ✔️ a customer should be able to complete an order without any issue.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Checkout Component: Quote Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jul 30, 2020
@kodubovik kodubovik mentioned this issue Jul 30, 2020
Merged
5 tasks
@ghost ghost assigned kodubovik Jul 30, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Jul 30, 2020
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Jul 30, 2020
@engcom-Alfa engcom-Alfa added Triage: Done Has been reviewed and prioritized during Triage with Product Managers Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Jul 31, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-36384 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: ready for dev and removed Progress: PR in progress labels Jul 31, 2020
@slavvka slavvka added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Aug 8, 2020
@slavvka
Copy link
Member

slavvka commented Aug 8, 2020

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #28902 by @kodubovik in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.1 release.

@slavvka slavvka closed this as completed Aug 8, 2020
@sdzhepa sdzhepa mentioned this issue May 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kodubovik kodubovik

Labels
Component: Checkout Component: Quote Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing bug with non-existent customer group breaking quote kodubovik/magento2
4 participants
@slavvka @kodubovik @magento-engcom-team @engcom-Alfa