-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Forwardport] Fix Missing meta title tag and doesn't show product name if meta title is empty #17771
[Forwardport] Fix Missing meta title tag and doesn't show product name if meta title is empty #17771
Conversation
… product name if meta title is empty
Hi @nmalevanec. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nmalevanec , why you skipped code fragment in ``processMetadataContent` method from original PR? Looks like this changes should be ported too
@sidolov, because 'processMetadataContent' in 2.3-develop seems more flexible and basically 'processMetadataContent' from original pr doesn't work because doesn't considering 'title' case.
|
Hi @sidolov, thank you for the review. |
…w product name if meta title is empty #17771
Hi @nmalevanec. Thank you for your contribution. |
Original Pull Request
#15532
Description
The current Magento behaviour does not allow to specify a title meta tag and the "Meta Title" option in the product's page is binded to the page's title.
This PR adds the meta tile tag and allows to use title and meta title independently.
Fixed Issues (if relevant)
Contribution checklist