Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Fix Missing meta title tag and doesn't show product name if meta title is empty #17771

Merged
merged 3 commits into from
Sep 13, 2018
Merged

Conversation

nmalevanec
Copy link
Contributor

@nmalevanec nmalevanec commented Aug 23, 2018

Original Pull Request

#15532

Description

The current Magento behaviour does not allow to specify a title meta tag and the "Meta Title" option in the product's page is binded to the page's title.

This PR adds the meta tile tag and allows to use title and meta title independently.

Fixed Issues (if relevant)

  1. M2.2.4 missing meta title tag and doesn't show product name if meta title is empty #15501: M2.2.4 missing meta title tag and doesn't show product name if meta title is empty

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @nmalevanec. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Contributor

@sidolov sidolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nmalevanec , why you skipped code fragment in ``processMetadataContent` method from original PR? Looks like this changes should be ported too

@nmalevanec
Copy link
Contributor Author

@sidolov, because 'processMetadataContent' in 2.3-develop seems more flexible and basically 'processMetadataContent' from original pr doesn't work because doesn't considering 'title' case.

 if ($name === 'title') {
            if (!$content) {
                $content = $this->escaper->escapeHtml($this->pageConfig->$method()->get());
            }
            return $content;
        }

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-2874 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @nmalevanec. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants