FIX for issue #15501 - M2.2.4 missing meta title tag and doesn't show… #15532
Conversation
…'t show product name if meta title is empty
| if (method_exists($this->pageConfig, $method)) { | ||
|
|
||
| // We skip title, because PageConfig::getTitle() refers to the tag <title> and not to meta title. | ||
| if (!in_array($name, ['title']) && method_exists($this->pageConfig, $method)) { |
There was a problem hiding this comment.
Why not use simple !== operator here? Also probably would be good to refactor code and avoid magic with method_exists check
There was a problem hiding this comment.
For readability, in case we need more methods to be skipped, but if you prefer I can refactor it with a single check
There was a problem hiding this comment.
I'd also suggest to keep a single check. I assume it's not the best way to skip more methods anyway, so if we would need more then we also would need a different solution.
| /** | ||
| * @param string $title | ||
| */ | ||
| public function setMetaTitle($title) |
There was a problem hiding this comment.
Please add type hint to the method to have more strict interface. Also to be consistent with other methods in this class it would be good to add corresponding getter
There was a problem hiding this comment.
Do you mean the whole class or just this method?
There was a problem hiding this comment.
Uhm, but if I am going to refactor with strict types for the class, I risk to add a backward incompatiblity. Are you sure?
There was a problem hiding this comment.
Yes for method only, I was saying something totally wrong on the previous comment. Sorry for the confusion.
|
@vkublytskyi , it should be ok now. Is there anything I should do on it? |
|
@phoenix128 For me it looks good. Thank you, your PR should be merged soon |
|
Hi @vkublytskyi, thank you for the review. |
|
Hi @phoenix128. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
FIX for issue #15501 - M2.2.4 missing meta title tag and doesn't show product name if meta title is empty
Description
The current Magento behaviour does not allow to specify a title meta tag and the "Meta Title" option in the product's page is binded to the page's title.
This PR adds the meta tile tag and allows to use title and meta title independently.
Fixed Issues (if relevant)
Contribution checklist