Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] 7691: address with saveInAddressBook 0 are still being added to the a… #16972

Closed

Conversation

gelanivishal
Copy link
Contributor

Original Pull request

#11903

If you place an order as a guest and set the save_in_address_book for an address on 0, that address will still be copied to the customer address book when registering as a new customer on the checkout success page.

Fixed Issues (if relevant)

  1. address with saveInAddressBook 0 are still being added to the address book for new customers #7691: address with saveInAddressBook 0 are still being added to the address book for new customers.

Manual testing scenarios

  1. Place an order as a guest and set the save_in_address_book for your shipping address to 0
  2. Click the register link on the checkout success page
  3. Addresses with save_in_address_book set to 0 should not be copied to the new customer address book.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@nuzil nuzil changed the title 7691: address with saveInAddressBook 0 are still being added to the a… [Backport] 7691: address with saveInAddressBook 0 are still being added to the a… Jul 20, 2018
@orlangur
Copy link
Contributor

orlangur commented Aug 1, 2018

@gelanivishal could you please not assign random people on PRs without their explicit will? Thanks in advance!

@orlangur orlangur removed their assignment Aug 1, 2018
@orlangur orlangur removed the request for review from ishakhsuvarov August 1, 2018 23:21
@sidolov sidolov self-assigned this Aug 6, 2018
@sidolov
Copy link
Contributor

sidolov commented Aug 6, 2018

Hi @gelanivishal , looks like implementation from 2.3 release line not compatible with code from 2.1 release line. Please, take a look at failed tests.

@sidolov
Copy link
Contributor

sidolov commented Aug 21, 2018

Hi @gelanivishal , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants