address with saveInAddressBook 0 are still being added to the address book for new customers

[koenner01]

If you place an order as a guest and set the save_in_address_book for an address on 0, that address will still be copied to the customer address book when registering as a new customer on the checkout success page.

Preconditions

1. PHP7.0
2. MG2 CE 2.1.2

Steps to reproduce

1. Place an order as a guest and set the save_in_address_book for your shipping address to 0
2. Click the register link on the checkout success page

Expected result

1. Every address that has save_in_address_book set to 0 should not be copied to the customer address book

Actual result

1. Addresses with save_in_address_book set to 0 are still copied to the new customer address book.

I traced this issue back to Magento\Sales\Model\Order\CustomerManagement where in the create() function a check should be added to see if the quote_address from where the order_address was copied from has a value 0 for save_in_address_book. If the value is 0, the address should not be copied.

public function create($orderId)
{
    $order = $this->orderRepository->get($orderId);
    if ($order->getCustomerId()) {
        throw new AlreadyExistsException(__("This order already has associated customer account"));
    }
    $customerData = $this->objectCopyService->copyFieldsetToTarget(
        'order_address',
        'to_customer',
        $order->getBillingAddress(),
        []
    );
    $addresses = $order->getAddresses();
    foreach ($addresses as $address) {
        $addressData = $this->objectCopyService->copyFieldsetToTarget(
            'order_address',
            'to_customer_address',
            $address,
            []
        );
        
        ...
}

Should be something like

protected $quoteAddressFactory;

public function __construct(
    ...
    \Magento\Quote\Model\Quote\AddressFactory $quoteAddressFactory
) {
    ...
    $this->quoteAddressFactory = $quoteAddressFactory;
}

public function create($orderId)
{
    $order = $this->orderRepository->get($orderId);
    if ($order->getCustomerId()) {
        throw new AlreadyExistsException(__("This order already has associated customer account"));
    }
    $customerData = $this->objectCopyService->copyFieldsetToTarget(
        'order_address',
        'to_customer',
        $order->getBillingAddress(),
        []
    );
    $addresses = $order->getAddresses();
    foreach ($addresses as $address) {
        $quoteAddressId = $address->getData('quote_address_id');
        if($quoteAddressId) {
            $quoteAddress = $this->quoteAddressFactory->create()->load($quoteAddressId);
            $saveInAddressBook = (int) $quoteAddress->getData('save_in_address_book');
            if ($saveInAddressBook === 0) {
                continue;
            }
        }

        ...

[magento-engcom-team]

@koenner01, thank you for your report.
We've created internal ticket(s) MAGETWO-81448 to track progress on the issue.

[okorshenko]

The issue has been fixed and delivered to 2.2-develop branch