Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7691: address with saveInAddressBook 0 are still being added to the address book for new customers(backport to 2.2) #12171

Merged
merged 1 commit into from
Nov 15, 2017

Conversation

RomaKis
Copy link
Contributor

@RomaKis RomaKis commented Nov 10, 2017

Backport from #11903.

If you place an order as a guest and set the save_in_address_book for an address on 0, that address will still be copied to the customer address book when registering as a new customer on the checkout success page.

Fixed Issues (if relevant)

  1. address with saveInAddressBook 0 are still being added to the address book for new customers #7691: address with saveInAddressBook 0 are still being added to the address book for new customers.

Manual testing scenarios

  1. Place an order as a guest and set the save_in_address_book for your shipping address to 0
  2. Click the register link on the checkout success page
  3. Addresses with save_in_address_book set to 0 should not be copied to the new customer address book.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added bugfix Component: Checkout Component: Customer Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release SQUASHTOBERFEST labels Nov 10, 2017
…ddress book for new customers(backport to 2.2)
@okorshenko okorshenko self-assigned this Nov 13, 2017
@okorshenko okorshenko added this to the November 2017 milestone Nov 13, 2017
@okorshenko okorshenko merged commit b750e58 into magento:2.2-develop Nov 15, 2017
okorshenko pushed a commit that referenced this pull request Nov 15, 2017
… added to the address book for new customers(backport to 2.2) #12171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Component: Checkout Component: Customer Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants