Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix, prevent displaying 0000-00-00 00:00:00 as anything else in admin grids #10598

Merged
merged 2 commits into from
Aug 23, 2017

Conversation

AntonEvers
Copy link
Contributor

@AntonEvers AntonEvers commented Aug 21, 2017

Description

The datetime 0000-00-00 00:00:00 is converted to a different time zone, leading to unexpected outcome. This string should be treated equal as NULL.

Fixed Issues (if relevant)

  1. none

Manual testing scenarios

  1. Add a '0000-00-00 00:00:00' date in the database in one of the sales grids
  2. Set the time zone to something exotic
  3. See that the 0000 time is turned into something meaningless, a random-ish date and time

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@AntonEvers AntonEvers closed this Aug 21, 2017
@orlangur
Copy link
Contributor

Is it used anywhere besides deprecated \Magento\Sales\Model\ResourceModel\AbstractGrid::getLastUpdatedAtValue method?

@hostep
Copy link
Contributor

hostep commented Aug 21, 2017

Not really related, but a similar problem can happen during the generation of the sitemap.xml files: #9151

@AntonEvers
Copy link
Contributor Author

@AntonEvers AntonEvers reopened this Aug 21, 2017
@ishakhsuvarov ishakhsuvarov added this to the August 2017 milestone Aug 21, 2017
@ishakhsuvarov ishakhsuvarov self-assigned this Aug 22, 2017
@magento-team magento-team merged commit 2f513bc into magento:develop Aug 23, 2017
magento-team pushed a commit that referenced this pull request Aug 23, 2017
magento-team pushed a commit that referenced this pull request Aug 23, 2017
[EngCom] Public Pull Requests
 - MAGETWO-71833: Grammar fix for #9533 #10627
 - MAGETWO-71801: FIX for issue 9930 - Asymmetric Transaction Error with ElasticSearch #10610
 - MAGETWO-71762: Bug fix, prevent displaying 0000-00-00 00:00:00 as anything else in admin grids #10598
 - MAGETWO-71532: Fix swagger-ui on instances of Magento running on a non-standard port #10504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants