Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix swagger-ui on instances of Magento running on a non-standard port #10504

Merged
merged 1 commit into from
Aug 23, 2017
Merged

Fix swagger-ui on instances of Magento running on a non-standard port #10504

merged 1 commit into from
Aug 23, 2017

Conversation

aredridel
Copy link
Contributor

@aredridel aredridel commented Aug 11, 2017 •
edited by okorshenko
Loading

No description provided.

@okorshenko okorshenko self-assigned this Aug 11, 2017
@okorshenko okorshenko added this to the August 2017 milestone Aug 11, 2017
@okorshenko
Copy link
Contributor

Hi @aredridel
Could you please provide more information about your PR? What is the issues, how to reproduce it and how this PR fixes the issue? Thank you

@okorshenko
Copy link
Contributor

Hi @aredridel
Could you please provide more information about your PR? Please, see my previous comment.

@aredridel
Copy link
Contributor Author

The issue is that if you run magento on say localhost:8082, the swagger-ui stuff doesn't work because the swagger doc says the endpoint is localhost, without a port.

@magento-team magento-team merged commit 236bda4 into magento:develop Aug 23, 2017
magento-team pushed a commit that referenced this pull request Aug 23, 2017
@ishakhsuvarov
MAGETWO-71532: Fix swagger-ui on instances of Magento running on a no…
d000df4 
…n-standard port #10504
magento-team pushed a commit that referenced this pull request Aug 23, 2017
@ishakhsuvarov
Merge pull request #1433 from magento-engcom/develop-prs
6c5ba1f 
[EngCom] Public Pull Requests
 - MAGETWO-71833: Grammar fix for #9533 #10627
 - MAGETWO-71801: FIX for issue 9930 - Asymmetric Transaction Error with ElasticSearch #10610
 - MAGETWO-71762: Bug fix, prevent displaying 0000-00-00 00:00:00 as anything else in admin grids #10598
 - MAGETWO-71532: Fix swagger-ui on instances of Magento running on a non-standard port #10504
This was referenced Dec 4, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@okorshenko okorshenko

Labels
Progress: accept Progress: needs update
Projects
None yet
Milestone
August 2017
Development

Successfully merging this pull request may close these issues.
3 participants
@aredridel @okorshenko @magento-team