#758: applied_taxes of empty cart causes 'Internal server error' message on PHP 7.2

[therealtbs]

Description (*)

From PHP 7.2 onward there is a warning generated when attempting to call count() on anything that is not an array or an object implementing Countable, when a cart is created, initially the appliedTaxes are null until a product is added.

Fixed Issues (if relevant)

1. Cart applied_taxes of empty cart causes 'Internal server error' message on PHP 7.2 #758: Cart applied_taxes of empty cart causes 'Internal server error' message on PHP 7.2

Manual testing scenarios (*)

1. See reproduction steps of Cart applied_taxes of empty cart causes 'Internal server error' message on PHP 7.2 #758

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[naydav]

Hi @therealtbs,

please cover this case (try to load cart taxes if taxes are not set) with API-functional tests
thanks

Examples:
https://github.com/magento/graphql-ce/tree/2.3-develop/dev/tests/api-functional/testsuite/Magento/GraphQl/Customer
https://github.com/magento/graphql-ce/tree/2.3-develop/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer

Guide:
https://devdocs.magento.com/guides/v2.3/graphql/functional-testing.html

[naydav]

Hi @TomashKhamlai
Please verify the fix.
Thanks

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-5436 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[magento-engcom-team]

@therealtbs thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[magento-engcom-team]

@therealtbs thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[magento-engcom-team]

@therealtbs thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[ghost]

Hi @therealtbs, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.