This repository has been archived by the owner on Dec 19, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 154
Cart applied_taxes of empty cart causes 'Internal server error' message on PHP 7.2 #758
Milestone
Comments
@therealtbs thanks for pointing out. Would you like to submit a PR to fix? If not I can this weekend. |
Sure, I'll get it going first thing tomorrow. |
therealtbs
pushed a commit
to therealtbs/graphql-ce
that referenced
this issue
Jun 28, 2019
4 tasks
therealtbs
pushed a commit
to therealtbs/graphql-ce
that referenced
this issue
Jun 30, 2019
therealtbs
pushed a commit
to therealtbs/graphql-ce
that referenced
this issue
Jun 30, 2019
therealtbs
pushed a commit
to therealtbs/graphql-ce
that referenced
this issue
Jun 30, 2019
magento-engcom-team
pushed a commit
that referenced
this issue
Jul 24, 2019
…r error' message on PHP 7.2 #759
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Preconditions (*)
Steps to reproduce (*)
Expected result (*)
Actual result (*)
graphql-ce/app/code/Magento/QuoteGraphQl/Model/Resolver/CartPrices.php
Line 76 in 21b3caf
At this point $appliedTaxes is NULL and therefore not countable. From PHP 7.2 onwards there is a warning generated which I assume Magento turns into a Throwable.
Since the fix is quite easy I'm not sure if I should make a PR for this.
The text was updated successfully, but these errors were encountered: