WIP: Resolve Async Error Handling Issues #412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ran `yarn-deduplicate` to resolve dependencies to fewest possible versions of each package being installed - Ran `yarn install` which even further pruned packages that were no longer necessary after deduplication
This removes `release-it` from it’s dependencies, which caused a lot of unnecessary packages to be installed
4eec61a to
b690c37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, this PR adds a probably-too-specific test for an error-handling error that I encounter in my app, by recreating the exact situation where it fails (in that the error catching is inside a helper, inside an Integration test)
I'm not sure yet what exactly a minimal reproduction looks like that could be done as a unit test.
Note: this includes #410 since the latest
ember-qunitversion was required to trigger the errorI also updated
ember-source, thinking that might be part of the problem since this addon is using a slightly older version. Updating that didn't start to surface the bug (I tried it before updating the test dependencies) but since I know the bug is reproducible with that version, I left the bump in this PR. We should drop that commit before this PR lands.Related to #409