Update Ember QUnit to V5 #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
|
@alexlafroscia mind running |
|
Can do! I ran it specifically for the Babel dependencies locally and it helped a bit. I'll run it for the whole file and push that up! |
- Ran `yarn-deduplicate` to resolve dependencies to fewest possible versions of each package being installed - Ran `yarn install` which even further pruned packages that were no longer necessary after deduplication
|
That helped a bunch! It's still a whole lot of additions, but at least there's like 800LOC of removals too. |
This was referenced Mar 4, 2021
maxfierke
approved these changes
Mar 4, 2021
looks good!|
Yup! That just happened so I'll do that update |
This removes `release-it` from it’s dependencies, which caused a lot of unnecessary packages to be installed
|
Much better diff numbers! |
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did this locally as part of investigating #409, and figured it would be worthwhile to up-stream this dependency bump since there are some set-up changes that are also required.