Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag editing improvements #1460

Open
6 tasks done
mwinokan opened this issue Jun 12, 2024 · 2 comments
Open
6 tasks done

Tag editing improvements #1460

mwinokan opened this issue Jun 12, 2024 · 2 comments
Assignees
@kaliif @matej-vavrek
Labels
2024-06-14 mint Data dissemination 2 backend frontend

Comments

@mwinokan
Copy link
Collaborator

mwinokan commented Jun 12, 2024 •
edited by matej-vavrek
Loading

Currently there is no way to edit the generated XCA tags that are not displayed in the tag details panel:

  • ConformerSites
  • CrystalformSites

Changes to the edit tags panel (F/E) @matej-vavrek:

  • Show ConformerSites & CrystalformSites tags in the edit dropdown. They should be editable except for their category and hidden property (which should always be True).
  • In the edit dropdown, please prepend and sort the tag names with their type
  • In the edit dropdown, the sites should be ordered numerically, at the moment the order is 1,10,11,12,2,3 and not 1,2,3...
  • Is it possible to show the tag colour in the dropdown?

Changes to the target loader for tags (B/E) @kaliif:

  • The ConformerSites and CrystalformSites tags should be treated like the CanonSites, etc. but with the hidden property set to True
  • Change the default colour of CrystalformSites so it's not the same as CanonSites (maybe red?)
@mwinokan mwinokan added the 2024-03-15 indigo Data dissemination loose ends label Jun 12, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Fragalysis Jun 12, 2024
@mwinokan mwinokan moved this from Backlog to FragTech in Fragalysis Jun 12, 2024
@phraenquex phraenquex added 2024-06-14 mint Data dissemination 2 and removed 2024-03-15 indigo Data dissemination loose ends labels Jun 14, 2024
@matej-vavrek matej-vavrek moved this from FragTech to In Progress (DEV) in Fragalysis Jun 27, 2024
@phraenquex
Copy link
Collaborator

Finishied, will be deployed along with #1458

@phraenquex phraenquex moved this from In Progress (DEV) to Dev Done - Do review (DEV) in Fragalysis Jul 4, 2024
@phraenquex phraenquex moved this from Dev Done - Do review (DEV) to In Progress (DEV) in Fragalysis Jul 4, 2024
@mwinokan
Copy link
Collaborator Author

The changes on @matej-vavrek's stack look great, ready for staging

@mwinokan mwinokan moved this from In Progress (DEV) to QA done in dev.env - move to staging in Fragalysis Jul 10, 2024
matej-vavrek added a commit that referenced this issue Jul 24, 2024
@matej-vavrek
#1460 allow to edit all tag categories, show colour and category in d…
19317ee 
…ropdown list and updated its sorting
@phraenquex phraenquex moved this from QA done in dev.env - move to staging to In staging - assess function vs spec in Fragalysis Jul 24, 2024
@phraenquex phraenquex moved this from In staging - assess function vs spec to Approved in staging - push to production in Fragalysis Jul 24, 2024
boriskovar-m2ms added a commit that referenced this issue Jul 25, 2024
@boriskovar-m2ms @matej-vavrek
Implements #1465, #1475, #1322, #1460 (#439)
f615596 
* #1465 changed /funders URL to point to landing page with open funders modal and also use this URL clicking on "Contributors" button in header, updated Route with 5.1 preferred style

* #1475 removed "Set as group name" for observations

* #1322 changed font weight for pose and observation titles, keep open observation modal on changing poses

* #1322 changed "group" to "pose", leave the LPC buttons visible, but grey them out without selection

* #1465 reverted "Contributors" button behavior, added copy funders button to funders modal

* #1465 added text to copy url button

* #1322 highlight selected pose, use singular names of tag categories, added expanded view mode, select all displayed and select all buttons, calculate height of window based on available space

* fixed some missing keys and pagination options for targets and projects

* #1460 allow to edit all tag categories, show colour and category in dropdown list and updated its sorting

---------

Co-authored-by: matej <matej.vavrek@m2ms.sk>
@mwinokan mwinokan moved this from Approved in staging - push to production to In production (Done) in Fragalysis Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaliif kaliif

@matej-vavrek matej-vavrek

Labels
2024-06-14 mint Data dissemination 2 backend frontend
Projects
Fragalysis
Status: In production (Done)
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kaliif @phraenquex @mwinokan @matej-vavrek