Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F/E interface to create and modify generated/XCA sites/tags #1458

Open
mwinokan opened this issue Jun 11, 2024 · 8 comments
Open

F/E interface to create and modify generated/XCA sites/tags #1458

mwinokan opened this issue Jun 11, 2024 · 8 comments
Assignees
@kaliif @matej-vavrek
Labels
2024-03-13 green Data dissemination 2024-06-14 mint Data dissemination 2 backend frontend

Comments

@mwinokan
Copy link
Collaborator

mwinokan commented Jun 11, 2024 •
edited
Loading

@matej-vavrek please have a look at adding some nested dropdowns to change the generated tags for all observations in a pose:

Image

If this is needlessly complicated please do suggest a simpler UI.

I suspect you will need some api endpoints from @kaliif to change the tags in the backend
@mwinokan mwinokan added the 2024-03-15 indigo Data dissemination loose ends label Jun 11, 2024
@mwinokan mwinokan self-assigned this Jun 11, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Fragalysis Jun 11, 2024
@mwinokan mwinokan moved this from Backlog to FragTech in Fragalysis Jun 11, 2024
@mwinokan mwinokan assigned kaliif and matej-vavrek and unassigned mwinokan Jun 13, 2024
@phraenquex phraenquex added 2024-06-14 mint Data dissemination 2 and removed 2024-03-15 indigo Data dissemination loose ends labels Jun 14, 2024
@mwinokan
Copy link
Collaborator Author

mwinokan commented Jun 27, 2024 •
edited
Loading

@boriskovar-m2ms says that the generated and curator tags are not treated differently in the b/e, jus that there is currently no f/e functionality to modify them

@mwinokan
Copy link
Collaborator Author

Longer discussion at the meeting w/ @phraenquex and @ConorFWild, to simplify the incremental uploads any generated tags that have been modified or created by the data curator should be separate from the machine-assigned sites from XCA.

@kaliif
Copy link
Collaborator

kaliif commented Jul 1, 2024

@matej-vavrek please describe which operations the backend needs to support for this ticket.

@matej-vavrek
Copy link
Collaborator

@kaliif it should be possible with current tag operations (or at least we assume)

@phraenquex phraenquex mentioned this issue Jul 4, 2024
Open
6 tasks
@matej-vavrek matej-vavrek moved this from FragTech to In Progress (DEV) in Fragalysis Jul 4, 2024
@mwinokan mwinokan moved this from In Progress (DEV) to FragTech in Fragalysis Jul 16, 2024
@Waztom Waztom moved this from FragTech to In Progress (DEV) in Fragalysis Jul 23, 2024
@mwinokan
Copy link
Collaborator Author

@matej-vavrek will need to return to it and finish off some adjustments. No B/E work needed

@mwinokan
Copy link
Collaborator Author

mwinokan commented Sep 3, 2024

@matej-vavrek is debugging some issues to complete this issue, but it should be fixed by next meeting

@matej-vavrek
Copy link
Collaborator

@mwinokan, I have updated my stack with a possible solution.

@mwinokan mwinokan moved this from In Progress (DEV) to Review Done - deploy to dev env (DEV) in Fragalysis Sep 10, 2024
@mwinokan mwinokan added the 2024-03-13 green Data dissemination label Sep 10, 2024
matej-vavrek added a commit that referenced this issue Sep 10, 2024
@matej-vavrek
#1458 allow to tag XCA sites, temp commit
fc9cd3e 
# Conflicts:
#	js/components/preview/molecule/observationsDialog.js
matej-vavrek added a commit that referenced this issue Sep 10, 2024
@matej-vavrek
#1458 adjusted functionality and styling to proper change tag
449eaa6
@mwinokan
Copy link
Collaborator Author

Tested on staging. Works as expected

@mwinokan mwinokan moved this from Review Done - deploy to dev env (DEV) to Approved in staging - push to production in Fragalysis Sep 10, 2024
matej-vavrek added a commit that referenced this issue Sep 12, 2024
@boriskovar-m2ms @matej-vavrek
#1458 (#446)
b32a185 
* Squashed commit of the following:

commit e613216
Author: Boris Kovar <boris.kovar@m2ms.sk>
Date:   Wed Jul 31 13:57:02 2024 +0200

    - implemented #1251

* #1482 added TagName and CentroidRes columns for expanded view of observation dialog

* #1489 show warning toast message if is defined on target load

* #1322 added longcode column

* updated general function for tag comparison

* #1505 adjusted getting of centroid_res

* #1458 allow to tag XCA sites, temp commit

# Conflicts:
#	js/components/preview/molecule/observationsDialog.js

* #1458 adjusted functionality and styling to proper change tag

---------

Co-authored-by: matej <matej.vavrek@m2ms.sk>
matej-vavrek added a commit that referenced this issue Sep 13, 2024
@matej-vavrek @boriskovar-m2ms
#1508 (#447)
3169e8f 
* Squashed commit of the following:

commit e613216
Author: Boris Kovar <boris.kovar@m2ms.sk>
Date:   Wed Jul 31 13:57:02 2024 +0200

    - implemented #1251

* #1482 added TagName and CentroidRes columns for expanded view of observation dialog

* #1489 show warning toast message if is defined on target load

* #1322 added longcode column

* updated general function for tag comparison

* #1505 adjusted getting of centroid_res

* #1458 allow to tag XCA sites, temp commit

# Conflicts:
#	js/components/preview/molecule/observationsDialog.js

* #1458 adjusted functionality and styling to proper change tag

* #1508 removed TagName column in expanded observation dialog, changed order of columns, adjusted labels and tooltips, show observation dialog in its full height

---------

Co-authored-by: Boris Kovar <boris.kovar@m2ms.sk>
@mwinokan mwinokan moved this from Approved in staging - push to production to In production (Done) in Fragalysis Sep 13, 2024
boriskovar-m2ms added a commit that referenced this issue Nov 26, 2024
@matej-vavrek @boriskovar-m2ms
#1508-1 (#449)
fdf2a7c 
* Squashed commit of the following:

commit e613216
Author: Boris Kovar <boris.kovar@m2ms.sk>
Date:   Wed Jul 31 13:57:02 2024 +0200

    - implemented #1251

* #1482 added TagName and CentroidRes columns for expanded view of observation dialog

* #1489 show warning toast message if is defined on target load

* #1322 added longcode column

* updated general function for tag comparison

* #1505 adjusted getting of centroid_res

* #1458 allow to tag XCA sites, temp commit

# Conflicts:
#	js/components/preview/molecule/observationsDialog.js

* #1458 adjusted functionality and styling to proper change tag

* #1508 removed TagName column in expanded observation dialog, changed order of columns, adjusted labels and tooltips, show observation dialog in its full height

* #1508 adjusted column order and width calculation

---------

Co-authored-by: Boris Kovar <boris.kovar@m2ms.sk>
boriskovar-m2ms added a commit that referenced this issue Nov 26, 2024
@matej-vavrek @boriskovar-m2ms
#1501 (#451)
c9dfbf4 
* Squashed commit of the following:

commit e613216
Author: Boris Kovar <boris.kovar@m2ms.sk>
Date:   Wed Jul 31 13:57:02 2024 +0200

    - implemented #1251

* #1482 added TagName and CentroidRes columns for expanded view of observation dialog

* #1489 show warning toast message if is defined on target load

* #1322 added longcode column

* updated general function for tag comparison

* #1505 adjusted getting of centroid_res

* #1458 allow to tag XCA sites, temp commit

# Conflicts:
#	js/components/preview/molecule/observationsDialog.js

* #1458 adjusted functionality and styling to proper change tag

* #1508 removed TagName column in expanded observation dialog, changed order of columns, adjusted labels and tooltips, show observation dialog in its full height

* #1508 adjusted column order and width calculation

* #1501 added upload links to menu

---------

Co-authored-by: Boris Kovar <boris.kovar@m2ms.sk>
boriskovar-m2ms added a commit that referenced this issue Nov 26, 2024
@matej-vavrek @boriskovar-m2ms
#1519 and #1520 (#453)
c68655e 
* Squashed commit of the following:

commit e613216
Author: Boris Kovar <boris.kovar@m2ms.sk>
Date:   Wed Jul 31 13:57:02 2024 +0200

    - implemented #1251

* #1482 added TagName and CentroidRes columns for expanded view of observation dialog

* #1489 show warning toast message if is defined on target load

* #1322 added longcode column

* updated general function for tag comparison

* #1505 adjusted getting of centroid_res

* #1458 allow to tag XCA sites, temp commit

# Conflicts:
#	js/components/preview/molecule/observationsDialog.js

* #1458 adjusted functionality and styling to proper change tag

* #1508 removed TagName column in expanded observation dialog, changed order of columns, adjusted labels and tooltips, show observation dialog in its full height

* #1508 adjusted column order and width calculation

* #1501 added upload links to menu

* #1520 show tag alias instead of upload_name on hit navigator CanonSites & ConformerSites box tooltip

* #1519 keep tag in edit window after save

---------

Co-authored-by: Boris Kovar <boris.kovar@m2ms.sk>
boriskovar-m2ms added a commit that referenced this issue Nov 26, 2024
@matej-vavrek @boriskovar-m2ms
#1497 (#454)
c244d20 
* Squashed commit of the following:

commit e613216
Author: Boris Kovar <boris.kovar@m2ms.sk>
Date:   Wed Jul 31 13:57:02 2024 +0200

    - implemented #1251

* #1482 added TagName and CentroidRes columns for expanded view of observation dialog

* #1489 show warning toast message if is defined on target load

* #1322 added longcode column

* updated general function for tag comparison

* #1505 adjusted getting of centroid_res

* #1458 allow to tag XCA sites, temp commit

# Conflicts:
#	js/components/preview/molecule/observationsDialog.js

* #1458 adjusted functionality and styling to proper change tag

* #1508 removed TagName column in expanded observation dialog, changed order of columns, adjusted labels and tooltips, show observation dialog in its full height

* #1508 adjusted column order and width calculation

* #1501 added upload links to menu

* #1520 show tag alias instead of upload_name on hit navigator CanonSites & ConformerSites box tooltip

* #1519 keep tag in edit window after save

* #1497 added Path column for extended view of observations

---------

Co-authored-by: Boris Kovar <boris.kovar@m2ms.sk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaliif kaliif

@matej-vavrek matej-vavrek

Labels
2024-03-13 green Data dissemination 2024-06-14 mint Data dissemination 2 backend frontend
Projects
Fragalysis
Status: In production (Done)
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kaliif @phraenquex @mwinokan @matej-vavrek