Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tough-cookie and node-gyp in /erizoAPI #1891

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 8, 2023

Removes tough-cookie. It's no longer used after updating ancestor dependency node-gyp. These dependencies need to be updated together.

Removes tough-cookie

Updates node-gyp from 7.1.2 to 9.4.0

Release notes

Sourced from node-gyp's releases.

node-gyp v9.4.0

Features

  • add support for native windows arm64 build tools (bb76021)
  • Upgrade Python linting from flake8 to ruff (#2815) (fc0ddc6)

Bug Fixes

  • extract tarball to temp directory on Windows (#2846) (aaa117c)
  • log statement is for devDir not nodedir (#2840) (55048f8)

Miscellaneous

  • get update-gyp.py to work with Python >= v3.5 (#2826) (337e8e6)

Doc

Tests

node-gyp v9.3.1

Bug Fixes

Miscellaneous

node-gyp v9.3.0

Features

... (truncated)

Changelog

Sourced from node-gyp's changelog.

9.4.0 (2023-06-12)

Features

  • add support for native windows arm64 build tools (bb76021)
  • Upgrade Python linting from flake8 to ruff (#2815) (fc0ddc6)

Bug Fixes

  • extract tarball to temp directory on Windows (#2846) (aaa117c)
  • log statement is for devDir not nodedir (#2840) (55048f8)

Miscellaneous

  • get update-gyp.py to work with Python >= v3.5 (#2826) (337e8e6)

Doc

Tests

9.3.1 (2022-12-16)

Bug Fixes

Miscellaneous

9.3.0 (2022-10-10)

Features

... (truncated)

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jul 8, 2023
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/erizoAPI/tough-cookie-and-node-gyp--removed branch from a52f7a1 to d046e3a Compare July 10, 2023 09:06
@lodoyun
Copy link
Contributor

lodoyun commented Aug 25, 2023

@dependabot rebase

Removes [tough-cookie](https://github.com/salesforce/tough-cookie). It's no longer used after updating ancestor dependency [node-gyp](https://github.com/nodejs/node-gyp). These dependencies need to be updated together.


Removes `tough-cookie`

Updates `node-gyp` from 7.1.2 to 9.4.0
- [Release notes](https://github.com/nodejs/node-gyp/releases)
- [Changelog](https://github.com/nodejs/node-gyp/blob/main/CHANGELOG.md)
- [Commits](nodejs/node-gyp@v7.1.2...v9.4.0)

---
updated-dependencies:
- dependency-name: tough-cookie
  dependency-type: indirect
- dependency-name: node-gyp
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/erizoAPI/tough-cookie-and-node-gyp--removed branch from d046e3a to 9efeb8f Compare August 25, 2023 08:52
Copy link
Contributor

@lodoyun lodoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested 👍

@lodoyun lodoyun merged commit 5467189 into master Aug 25, 2023
@lodoyun lodoyun deleted the dependabot/npm_and_yarn/erizoAPI/tough-cookie-and-node-gyp--removed branch August 25, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant