Update to Ubuntu 20.04 #1635

Arri98 · 2020-09-17T16:19:48Z

Description

Updated installer and dockerfile to Ubuntu 20.04 and gcc7:

Updated dockerfile for Ubuntu 20.04.
installUbuntuDeps checks Ubuntu version and installs gcc7 for Ubunutu 18 and 20 and gcc5 for other versions for retrocompability.
Updated python2 to python3.
Cpplint installed with conan and removed cpplint file which used python2.
Audited npm packages and updated those who don't need aditional changes.
Increased sleep time after rabitmq in initDockerLicode to prevent docker image for failing at start

With these changes docker images can be compiled from Ubuntu 16.04, 18.04 and 20.04 and installation from source works for Ubuntu 16.04 and 20.04 (Installation in Ubuntu 18.04 has not been tested but should work). With gcc7 additional warnings appear in some libraries that are no longer been updated but installation works.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

No changes where made

[] It includes documentation for these changes in /doc.

Arri98 · 2020-09-17T19:23:35Z

Build is failing in erizo lint and I think it is because python 3 is installed instead of python 2 and the cpplint file that erizo has needs python 2.

From CircleCI:
Scanning dependencies of target lint
Executing lint
/bin/sh: 1: /opt/licode/erizo/src/../utils/cpplint.py: Permission denied
make[3]: *** [CMakeFiles/lint.dir/build.make:58: CMakeFiles/lint] Error 126
make[2]: *** [CMakeFiles/Makefile2:196: CMakeFiles/lint.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:203: CMakeFiles/lint.dir/rule] Error 2
make: *** [Makefile:155: lint] Error 2

Exited with code exit status 2

jcague

Great contribution! I have some minor comments to understand some of the updates better. Nothing makes me think this won't work, but I first want to test it in different environments, because it implies many indirect changes, mainly new versions of third-party dependencies. Also, old hidden bugs could arise due to updating GCC, so I prefer to be a bit careful.

jcague · 2020-09-28T14:34:43Z

Dockerfile

@@ -1,9 +1,12 @@
-FROM ubuntu:16.04
+FROM ubuntu:20.04


jcague · 2020-09-28T14:34:59Z

Dockerfile


 MAINTAINER Lynckia

 WORKDIR /opt

+#Configure tzdata


Suggested change

#Configure tzdata

# Configure tzdata

jcague · 2020-09-28T14:35:56Z

Dockerfile


 MAINTAINER Lynckia

 WORKDIR /opt

+#Configure tzdata
+ENV TZ=Europe/Madrid


why do we need to set the timezone here?

With Ubuntu 20, when running apt-get update the library tzdata will install and stop the docker build to ask the user for their timezone. The problem is that even when the user introduces the timezone, docker build gets stuck so I had to set the timezone before.

jcague · 2020-09-28T14:38:10Z

extras/docker/initDockerLicode.sh

@@ -62,7 +64,7 @@ check_result() {
 run_rabbitmq() {
  echo "Starting Rabbitmq"
  rabbitmq-server -detached
-  sleep 3
+  sleep 5


jcague · 2020-09-28T14:40:43Z

scripts/installUbuntuDeps.sh

@@ -91,6 +100,12 @@ install_conan(){
  pip3 install conan==1.21
 }

+install_cpplint(){
+   sudo pip3 install cpplint==1.5.4


I think we also need to add cpplint as a dep into the installMacDeps.sh, but I can do it in a different PR if you don't have access to a Mac.

Yes we should because all scripts no longer call the cpplint.py file that was removed. I don't have access to a Mac so if you could do it it would be perfect.

jcague · 2020-09-28T14:42:29Z

scripts/installErizo.sh

@@ -21,6 +21,7 @@ elif [ "$(expr substr $(uname -s) 1 5)" == "Linux" ]; then
 fi

 export ERIZO_HOME=$ROOT/erizo
+export PATH=$HOME/.local/bin:$PATH; conan


is this something needed now with Ubuntu 20.04?

I'm not sure if it is because Ubuntu 20.04 but without it the script wouldn't find conan. For what I have seen, pip doesn't install conan globally and the shell wouldn't find it if I don't specify the path.

jcague · 2020-09-28T14:44:18Z

Dockerfile

@@ -29,6 +32,8 @@ RUN ./installErizo.sh -dfeacs && \
    ./../nuve/installNuve.sh && \
    ./installBasicExample.sh

+RUN ldconfig /opt/licode/build/libdeps/build/lib


why do we need to use ldconfig?

When running erizo tests the script wasn't able to find the libraries installed in /opt/licode/build/libdeps/build/lib

1: Test command: /opt/licode/erizo/build/debug/test/tests
1: Test timeout computed to be: 10000000
1: /opt/licode/erizo/build/debug/test/tests: error while loading shared libraries: libavresample.so.2: cannot open shared object file: No such file or directory
1/1 Test #1: all ..............................***Failed 0.00 sec

I had to run ldconfig to add the links to the path. I didn't want to modify the dockerfile and run ldfconfig in the installUbuntuDeps file but it wasn't working as intended.

jcague · 2020-09-28T14:47:06Z

nuve/package-lock.json

-      "version": "4.17.15",
-      "resolved": "https://registry.npmjs.org/lodash/-/lodash-4.17.15.tgz",
-      "integrity": "sha512-8xOcRHvCjnocdS5cpwXQXVzmmh5e5+saE2QGoeQmbKmRS6J3VQppPOIt0MnmE+4xlZoumy0GPG0D0MVIQbNA1A=="
+      "version": "4.17.20",


Is there ar reason to update the version of these libraries with Ubuntu 20.04? If not, I'd rather submit this package-lock.json files in another different PR to simplify the way we can test stuff.

There is no particular reason, but there were some medium and high severity vulnerabilities. Most of them could be fixed automatically with npm audit fix but installation works without updating the libraries.

jcague · 2020-09-28T14:48:42Z

scripts/initLicode.sh

@@ -21,6 +21,7 @@ cd $ROOT/nuve
 sleep 5

 export ERIZO_HOME=$ROOT/erizo/
+export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$ROOT/build/libdeps/build/lib 


I think I'm a bit lost with the new usage of LD_LIBRARY_PATH and ldconfig in this PR. Can you explain in a few words why do we need them?

As I commented before, when updating to Ubuntu 20 the script wheren't able to find the libdeps libraries. This was the first attempt to add the path to the libraries to the bash and fixed some of the problems but not all of them. I have to check if this command is redundant after running ldconfig.

jcague · 2020-09-28T14:55:05Z

scripts/installUbuntuDeps.sh

-  sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-5 60 --slave /usr/bin/g++ g++ /usr/bin/g++-5
+  if [[ $(lsb_release -rs) == "18.04" ]] || [[ $(lsb_release -rs) == "20.04" ]] ; then 
+      echo "Installing gcc7"
+      sudo apt-get install -qq git make gcc-7 g++-7 python3-pip libssl-dev cmake pkg-config liblog4cxx-dev rabbitmq-server mongodb curl autoconf libtool automake -y


I think you can split this apt-get install command and install mongodb, rabbitmq, curl, etc outside of the condition. Another alternative is to set the GCC version on a global var and use it with something like sudo apt-get install ... gcc-$(gcc_version)....

Ok, I'll change it.

Arri98 · 2020-10-05T08:27:37Z

Changes in the last commit:

Reverted package update.
Removed an unnecessary LD_LIBRARY_PATH export.
Installed conan with sudo so I don't have to export the route.
Small refractor to installUbuntuDeps.

jcague

This looks good to me! We have been testing it for a while in a dev environment with 0 issues.

jcague · 2020-10-16T09:11:33Z

@Arri98 thanks a lot! this is a great contribution!

aalonsog · 2020-10-16T10:02:56Z

👏

arri added 4 commits September 14, 2020 12:42

Updated Dockerfile and installer to Ubuntu 20.04

8ac8411

Gcc5 for ubuntu 16

334652c

Merge branch 'master' of https://github.com/lynckia/licode

854c7cd

Increased sleep after rabitmq

e6b277f

arri and others added 8 commits September 18, 2020 12:03

Readded cpplint file and python2 for tests

77ad46c

Added route to libraries to bashrc

7e58bf3

Force v8 promise resolving to publish/subscriber faster (#1633)

c2c3b98

Add more detail to unhandled promises error log (#1634)

4b01584

Fix problems with logs (#1626)

e898774

Correctly added libraries routes

3c34815

Fix: Removed unnecessary sleep

f253be6

Fix: Removed leftovers calls to cpplint.py

6eaeefc

jcague reviewed Sep 28, 2020

View reviewed changes

arri added 2 commits October 2, 2020 10:44

Merge branch 'master' of https://www.github.com/Arri98/licode

29677e8

Package rollback and small changes in script

b461a85

jcague approved these changes Oct 16, 2020

View reviewed changes

jcague merged commit 8a1eb05 into lynckia:master Oct 16, 2020

Arri98 added a commit to Arri98/licode that referenced this pull request Apr 6, 2021

Update to Ubuntu 20.04 (lynckia#1635)

47bdeac

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to Ubuntu 20.04 #1635

Update to Ubuntu 20.04 #1635

Arri98 commented Sep 17, 2020

Arri98 commented Sep 17, 2020

jcague left a comment

jcague Sep 28, 2020

jcague Sep 28, 2020

jcague Sep 28, 2020

Arri98 Sep 29, 2020

jcague Sep 28, 2020

jcague Sep 28, 2020

Arri98 Sep 29, 2020

jcague Sep 28, 2020

Arri98 Sep 29, 2020

jcague Sep 28, 2020

Arri98 Sep 29, 2020

jcague Sep 28, 2020

Arri98 Sep 29, 2020

jcague Sep 28, 2020

Arri98 Sep 29, 2020

jcague Sep 28, 2020

Arri98 Sep 29, 2020

Arri98 commented Oct 5, 2020

jcague left a comment

jcague commented Oct 16, 2020

aalonsog commented Oct 16, 2020

Update to Ubuntu 20.04 #1635

Update to Ubuntu 20.04 #1635

Conversation

Arri98 commented Sep 17, 2020

Arri98 commented Sep 17, 2020

jcague left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Arri98 commented Oct 5, 2020

jcague left a comment

Choose a reason for hiding this comment

jcague commented Oct 16, 2020

aalonsog commented Oct 16, 2020