Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problems with logs #1626

Merged
merged 2 commits into from
Sep 21, 2020
Merged

Fix problems with logs #1626

merged 2 commits into from
Sep 21, 2020

Conversation

lodoyun
Copy link
Contributor

@lodoyun lodoyun commented Aug 19, 2020 •
edited
Loading

Description
This PR fixes a couple of problems introduced recently in logs.

  1. Fix the Connecting to Room log. It now properly logs the token and we remove the RoomId since it is never present and it can be confusing.
  2. Logs would produce an error if a stream does not have attributes

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.

@lodoyun lodoyun changed the title Fix connecting to room log Fix problems with logs Aug 19, 2020
@lodoyun lodoyun mentioned this pull request Aug 19, 2020
Open
jcague
jcague approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@lodoyun lodoyun merged commit e898774 into lynckia:master Sep 21, 2020
@lodoyun lodoyun deleted the fix/ConnectRoomLog branch September 21, 2020 12:44
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
@lodoyun
Fix problems with logs (lynckia#1626)
8d04d77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcague jcague jcague approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lodoyun @jcague