Fixing a simple bug in browser version detection #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates canary versions to current ones and adds a fallback to "some unknown chrome version" just in case.
|
Thanks for the pull request!It fixes a current bug in the code so it's more than welcome. We'll try it these days and accept it after all. |
aalonsog
pushed a commit
that referenced
this pull request
Jun 10, 2013
Fixing a simple bug in browser version detection
lodoyun
pushed a commit
that referenced
this pull request
Dec 14, 2016
Merge ging:master to development
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As current dev and canary versions of chrome are numbered '29', erizo_client have stopped functioning properly.
Obvious bug is that erizo can't understand that user is using chrome and tries to detect 'bowser' version and then it raises unhandled "Cannot read the property [1] of null" exception.
Commit to fix that bug is really simple and is almost self-descriptive.