Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaffold test files to src/__tests__ + small fixes #2339

Merged
merged 6 commits into from
Feb 5, 2019
Merged

Scaffold test files to src/__tests__ + small fixes #2339

merged 6 commits into from
Feb 5, 2019

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Feb 5, 2019

This is the last pull request in my series of small changes migrating our test files from test to src/__tests__.

The first commit reworks our CLI templates to scaffold test files to src/__tests__.

The remaining commits are fixing places that I forgot to update in my previous pull requests #2283, #2316 and #2330.

See also #1636.

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

bajtos added 6 commits February 5, 2019 10:22
@bajtos
feat(cli): scaffold test files to src/__tests__
27b4dea 
Rework our project templates to place test files to `src/__tests__`.

- Source files are compiled from `src/{foo}` to `dist/{foo}`, the same
  pattern is applied to test files too.

- Both TypeScript sources and JavaScript output are stored in the same
  path relative to project root. This makes it much easier to refer
  to test fixtures.

This is a follow-up for 066d525, 91a37dc and 1a6ac91.
@bajtos
fix(benchmark): set TypeScript's rootDir to src
83a971c
@bajtos
feat(build): use dist/__tests__ in code examples and tests
d2f6442
@bajtos
fix(example-todo): "npm run migration" script path
adcca0e
@bajtos
fix(example-todo-list): "npm run migration" script path
e88d074
@bajtos
fix(docs): update test paths to src/__tests__
c268d5a
@bajtos bajtos force-pushed the refactor/templates-test-dir branch from fa6c3d2 to c268d5a Compare February 5, 2019 09:22
@bajtos bajtos self-assigned this Feb 5, 2019
hacksparrow
hacksparrow approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@hacksparrow hacksparrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

b-admike
b-admike approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@b-admike b-admike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see src/test anywhere, LGTM.

@bajtos bajtos merged commit 75731f9 into master Feb 5, 2019
@bajtos bajtos deleted the refactor/templates-test-dir branch February 5, 2019 16:35
@bajtos bajtos mentioned this pull request Mar 18, 2019
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-admike b-admike b-admike approved these changes

@hacksparrow hacksparrow hacksparrow approved these changes

@raymondfeng raymondfeng raymondfeng approved these changes

Assignees

@bajtos bajtos

Labels
CLI feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bajtos @raymondfeng @hacksparrow @b-admike