build: move test files to src/__tests__ in packages
#2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondfeng
approved these changes
Feb 4, 2019
bc883b5 to
dcb7bdd
Compare
- Source files are compiled from `src/{foo}` to `dist/{foo}`, the same
pattern is applied to test files too.
- Both TypeScript sources and JavaScript output are stored in the same
path relative to project root. This makes it much easier to refer
to test fixtures.
This is a follow-up for 066d525 and 91a37dc.
dcb7bdd to
ed590c8
Compare
bajtos
commented
Feb 5, 2019
| "packages/*/dist/__tests__/", | ||
| "packages/cli/test/", | ||
| "examples/*/dist/test/", | ||
| "examples/*/dist/__tests__/", |
There was a problem hiding this comment.
I should have made this change in the previous pull request. I think the drop in code coverage is caused by the fact that before, we were including test files in example projects in lines-to-be-covered. Test files usually have 100% coverage, which is skewing the coverage value upwards.
**coverage/coveralls ** — Coverage decreased (-0.8%) to 90.429%
This was referenced Feb 5, 2019
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source files are compiled from
src/{foo}todist/{foo}, the samepattern is applied to test files too.
Both TypeScript sources and JavaScript output are stored in the same
path relative to project root. This makes it much easier to refer
to test fixtures.
This is a follow-up for 066d525 (#2283) and 91a37dc (#2316), see also #1636.
Out of scope: refactor project (app & extension) templates, I'll open another PR for that.
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated