ci: refactor node controller unit tests #2380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4818623 to
39776e2
Compare
PhanLe1010
previously approved these changes
Dec 18, 2023
39776e2 to
3a5d6b2
Compare
Refactor node controller unit tests: - Break up single test function into multiple test functions - Create a clear separation between test case input data and expected result data - Implement existing tests with new structure as individual test functions - Avoid checking things that aren't subject matter of the test case at hand related-to: longhorn/longhorn#7332 Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
- Rename "TestCase" to "NodeControllerFixture" - Rename "Expectation" to "NodeControllerExpectation" - Avoid passing unnecessary parameters to test helper functions - Use "checkDiskConditions" test helper function in all places where disk conditions need to be tested Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
3a5d6b2 to
f9344c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor node controller unit tests:
related-to: longhorn/longhorn#7332