Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Torch Dialect] add fold pattern for aten.clone #2804

Merged
merged 2 commits into from
Jan 31, 2024
Merged

[Torch Dialect] add fold pattern for aten.clone #2804

merged 2 commits into from
Jan 31, 2024

Conversation

qingyunqu
Copy link
Collaborator

No description provided.

@qingyunqu qingyunqu requested a review from ramiro050 January 26, 2024 03:32
ramiro050
ramiro050 requested changes Jan 26, 2024
View reviewed changes
lib/Dialect/Torch/IR/TorchOps.cpp Outdated Show resolved Hide resolved
@qingyunqu qingyunqu requested a review from ramiro050 January 29, 2024 16:10
newling
newling reviewed Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@newling newling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally if no new operations are created, it is implemented as a fold method not a canonicalize method.

See for example AtenRoundOp (hasFolder, fold).

@qingyunqu qingyunqu changed the title [Torch Dialect] add canoncailize pattern for aten.clone [Torch Dialect] add fold pattern for aten.clone Jan 30, 2024
@qingyunqu
Copy link
Collaborator Author

Generally if no new operations are created, it is implemented as a fold method not a canonicalize method.

See for example AtenRoundOp (hasFolder, fold).

ok, done.

@qingyunqu qingyunqu requested a review from Vremold January 30, 2024 04:30
ramiro050
ramiro050 approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@ramiro050 ramiro050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qingyunqu qingyunqu merged commit d778950 into llvm:main Jan 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newling newling newling left review comments

@ramiro050 ramiro050 ramiro050 approved these changes

@Vremold Vremold Awaiting requested review from Vremold

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qingyunqu @newling @ramiro050