-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(changelog): version 1.3.0 [citest skip] #66
Conversation
CHANGELOG.md
Outdated
Add two new variables, allowing the rate limit to be configured using the role. | ||
|
||
Reason: | ||
IHAC which needs these settings to be changed from their default values, and they would like to use RHEL System Roles as much as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think lines 10 to 15 should be removed here as it doesn't sound right for a change log entry.
When I filled out the pull request template I wasn't aware that the body would be included in the change log, so now it comes out a bit weird (especially the "Reason" part).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, we have automation that just automatically builds the changelog entries from the PR.
I suppose we could require two additional doc fragments when submitting a PR - one for the PR body with the details and the reason, and one for the changelog snippet, but that seems like too much overhead.
I agree in this case that it doesn't really add anything to the changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spetrosi done! :)
CHANGELOG.md
Outdated
|
||
Enhancement: | ||
Add two new variables, allowing the rate limit to be configured using the role. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markdown needs an empty line to render text on an new line. Text on two following lines is rendered as a single line.
CHANGELOG.md
Outdated
### Other Changes | ||
|
||
- ci: fix python unit test - copy pytest config to tests/unit (#62) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CHANGELOG.md
Outdated
|
||
- ci: fix python unit test - copy pytest config to tests/unit (#62) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CHANGELOG.md
Outdated
|
||
|
||
- ci: Bump ansible/ansible-lint from 6 to 24 (#63) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ed61163
to
14ea154
Compare
Update changelog and .README.html for version 1.3.0 Signed-off-by: Sergei Petrosian <spetrosi@redhat.com>
Update changelog and .README.html for version 1.3.0
Signed-off-by: Sergei Petrosian spetrosi@redhat.com