Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add options for rate limit interval and burst #64

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

ephracis
Copy link
Contributor

@ephracis ephracis commented Mar 22, 2024

Add two new variables, allowing the rate limit to be configured using the role.

Add two new variables, allowing the rate limit to be configured using
the role.
@ephracis ephracis requested review from spetrosi and richm as code owners March 22, 2024 10:23
@spetrosi
Copy link
Contributor

lgtm, please change a test for new variables.

@ephracis
Copy link
Contributor Author

Thanks for the fast response. I added the variables to tests_example.yml. Please let me know if there's anything else.

@spetrosi
Copy link
Contributor

[citest]

@spetrosi
Copy link
Contributor

Please prefix the PR title with feat: to indicate that this PR adds a new feature. And let's wait for the CI tests.

@richm richm changed the title Add options for rate limit feat: Add options for rate limit interval and burst Mar 22, 2024
@ephracis ephracis changed the title feat: Add options for rate limit interval and burst feat: Add options for rate limit Mar 22, 2024
@ephracis ephracis changed the title feat: Add options for rate limit feat: Add options for rate limit interval and burst Mar 22, 2024
@richm
Copy link
Contributor

richm commented Mar 22, 2024

[citest]

@richm richm merged commit d1984a4 into linux-system-roles:main Mar 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants