Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get size,objects fields in object storage bucket exposed to terrafrom #783

Merged
merged 4 commits into from
Mar 30, 2023
Merged

Get size,objects fields in object storage bucket exposed to terrafrom #783

merged 4 commits into from
Mar 30, 2023

Conversation

yec-akamai
Copy link
Contributor

@yec-akamai yec-akamai commented Mar 28, 2023 •
edited
Loading

📝 Description

As a follow up to linode/linodego#316, we make the two new fields, size and objects, available in the object storage bucket datasource in terraform.

https://jira.linode.com/browse/TPT-1837

✔️ How to Test

Use replace directive in the go.mod file to have the linodego change available locally. Also released linodego v1.16.0 to have the change in production, and updated the linodego version in terraform.

Run the follow command to test:

make PKG_NAME="linode/objbucket" TESTARGS="-run TestAccDataSourceBucket_basic" testacc

=== RUN   TestAccDataSourceBucket_basic
=== PAUSE TestAccDataSourceBucket_basic
=== CONT  TestAccDataSourceBucket_basic
--- PASS: TestAccDataSourceBucket_basic (20.62s)
PASS
ok  	github.com/linode/terraform-provider-linode/linode/objbucket	23.444s

@yec-akamai yec-akamai requested a review from a team March 28, 2023 20:02
@yec-akamai
Copy link
Contributor Author

/acctest sha=3f30a6ed377446bf46aac90aa6820eb3eb7fa08f pkg=linode/…

@yec-akamai yec-akamai requested review from a team and removed request for a team March 29, 2023 16:22
@zliang-akamai
Copy link
Member

/acctest sha=3f30a6ed377446bf46aac90aa6820eb3eb7fa08f pkg=linode/objbucket

@zliang-akamai
Copy link
Member

/acctest sha=d98412d8be84ce04f3780f3e74ef1e1f4e6dd426 pkg=linode/objbucket

@yec-akamai yec-akamai merged commit e2062ad into dev Mar 30, 2023
@yec-akamai yec-akamai deleted the TPT-1837/get-objbucket-missed-fields-exposed branch March 30, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zliang-akamai zliang-akamai zliang-akamai approved these changes

@ezilber-akamai-zz ezilber-akamai-zz ezilber-akamai-zz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yec-akamai @zliang-akamai @ezilber-akamai-zz