Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add size,objects fields back to obj bucket #316

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

yec-akamai
Copy link
Contributor

📝 Description

The size and objects were removed in 2019 due to a beta change. Now they've been added back to the object storage bucket API response. We need to add them back in linodego and terraform (follow-up).

✔️ How to Test

make testunit
make testint

@yec-akamai yec-akamai requested a review from a team March 24, 2023 20:13
Copy link
Contributor

@jcallahan-akamai jcallahan-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Not required, but we could probably expand the tests to look for these specific fields.

@yec-akamai
Copy link
Contributor Author

Looks good. Not required, but we could probably expand the tests to look for these specific fields.

Thank you! The fixture generated for integration tests already include the newly added fields. We'll also have some tests in terraform to look for these fields. I'm working on https://jira.linode.com/browse/TPT-1837 to get these fields exposed to terraform and will add the test case there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants