Rendering performance improvements by simplifying logging #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 7, 2014 16:38
…e performance of the logging function
|
Looks good. Are the percentages all compared to Dust 1.2.6? |
|
@smfoote Yup, that's right. |
|
Looks good though should this be in 2.1 and 2.3 as well? we may need to |
|
@jimmyhchan it will be in 2.3.5 for the next release, since the code changes will be on master, but the release process is separated from Pull Requests after 2.3.x. I've abandoned non breaking bug fixes for 2.1.x, since we're using 2.2.x now. |
|
Aside this was a introduced in 2.1 we should push another 2.1. Up to you |
added 3 commits
May 7, 2014 18:11
…improve render performance
|
@jimmyhchan updated with 2.1.x code change and perf numbers |
|
Thanks. Looks good |
|
Looks good @prashn64 ! Commit history and merges into 2.1.x, 2.2.x and 2.3.x look good as well. |
kate2753
added a commit
that referenced
this pull request
May 8, 2014
Rendering performance improvements by simplifying logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Average of three runs of the benchmark tool (Total 30,000 iterations for each suite) with v1.2.6 as the baseline
v1.2.6
ops/ms
string: 2406 | 0%
replace: 546 | 0%
array: 633 | 0%
object: 512 | 0%
partial: 247 | 0%
recursion: 367 | 0%
filter: 743 | 0%
complex: 321 | 0%
v2.0.0
ops/ms
string: 2128 | -11%
replace: 518 | -5%
array: 579 | -8%
object: 483 | -5%
partial: 234 | -5%
recursion: 329 | -10%
filter: 652 | -12%
complex: 296 | -7%
v2.1.4
ops/ms
string: 2472 | +11%
replace: 404 | -26%
array: 381 | -39%
object: 381 | -25%
partial: 160 | -35%
recursion: 180 | -51%
filter: 538 | -27%
complex: 178 | -44%
v2.2.9
ops/ms
string: 2671 | +11%
replace: 352 | -35%
array: 308 | -51%
object: 333 | -34%
partial: 142 | -42%
recursion: 156 | -57%
filter: 368 | -50%
complex: 133 | -58%
v2.3.4
ops/ms
string: 2558 | +6%
replace: 464 | -15%
array: 338 | -46%
object: 343 | -33%
partial: 144 | -41%
recursion: 156 | -57%
filter: 376 | -49%
complex: 133 | -58%
v2.1.5 (THIS PR)
ops/ms
string: 2540 | +5%
replace: 582 | +6%
array: 602 | -5%
object: 525 | +2%
partial: 216 | -12%
recursion: 290 | -20%
filter: 720 | -3%
complex: 318 | -1%
v2.2.10 (THIS PR)
ops/ms
string: 2708 | +12%
replace: 508 | -2%
array: 570 | -1%
object: 477 | -1%
partial: 206 | -11%
recursion: 255 | -22%
filter: 507 | -22%
complex: 234| -20%
master (THIS PR)
ops/ms
string: 2883 | +19%
replace: 673 | +30%
array: 552 | -5%
object: 520 | +7%
partial: 219 | -6%
recursion: 274 | -16%
filter: 527 | -19%
complex: 236 | -20%