Merge pull request #463 from prashn64/perf-logging

Rendering performance improvements by simplifying logging
linkedin · May 8, 2014 · a56ea05 · a56ea05
2 parents 85d78c5 + 61a8477
commit a56ea05
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 29 deletions.
diff --git a/lib/dust.js b/lib/dust.js
@@ -46,13 +46,8 @@
    * @public
    */
   dust.log = function(message, type) {
-    if(dust.isDebug && dust.debugLevel === NONE) {
-      logger.log('[!!!DEPRECATION WARNING!!!]: dust.isDebug is deprecated.  Set dust.debugLevel instead to the level of logging you want ["debug","info","warn","error","none"]');
-      dust.debugLevel = INFO;
-    }
-
     type = type || INFO;
-    if (dust.indexInArray(loggingLevels, type) >= dust.indexInArray(loggingLevels, dust.debugLevel)) {
+    if (dust.debugLevel !== NONE && dust.indexInArray(loggingLevels, type) >= dust.indexInArray(loggingLevels, dust.debugLevel)) {
       if(!dust.logQueue) {
         dust.logQueue = [];
       }
@@ -232,7 +227,6 @@
         var name = filters[i];
         if (name === 's') {
           auto = null;
-          dust.log('Using unescape filter on [' + string + ']', DEBUG);
         }
         else if (typeof dust.filters[name] === 'function') {
           string = dust.filters[name](string);
@@ -326,7 +320,6 @@
     var ctx = this.stack,
         i = 1,
         value, first, len, ctxThis;
-    dust.log('Searching for reference [{' + down.join('.') + '}] in template [' + this.getTemplateName() + ']', DEBUG);
     first = down[0];
     len = down.length;
 

diff --git a/test/jasmine-test/spec/coreTests.js b/test/jasmine-test/spec/coreTests.js
@@ -1800,27 +1800,6 @@ var coreTests = [
         log:    "Invalid filter [nullcheck]",
         message: "should fail hard for invalid filter"
       },
-      {
-        name: "Using unescape filter",
-        source:"{test|s}",
-        context: {"test": "example text"},
-        log: "Using unescape filter on [example text]",
-        message: "test the log messages for an unescape filter."
-      },
-      {
-        name: "Reference lookup",
-        source:"{test}",
-        context: {"test": "example text"},
-        log: "Searching for reference [{test}] in template [Reference lookup]",
-        message: "test the log messages for a reference lookup."
-      },
-      {
-        name: "Reference lookup with dots",
-        source:"{test.anotherTest}",
-        context: {"test": "example text"},
-        log: "Searching for reference [{test.anotherTest}] in template [Reference lookup with dots]",
-        message: "test the log messages for a reference lookup."
-      },
       {
         name: "Reference not found",
         source:"{wrongTest}",