Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix our release process + add bower.json + jshint + cleanup master #371

Merged
merged 28 commits into from
Dec 7, 2013

Conversation

jimmyhchan
Copy link
Contributor

For issues #361, #365, #366, #369, #364

List of changes

  • Move from make to grunt
  • Fixed our tests so they build before everything before a run. Jasmine specRunners are now created automagically with grunt.
  • Fix our release process to use grunt-release. Now it's a one step process with compressed zip/tarballs autogenerated.
  • jshint the most important stuff (other files like the test specs TBD)
  • added bower.json
  • fixed our .gitignore and added .npmignore so that modules that got npm installed are lean
  • move from cover to istanbul
  • created 'tmp' and 'archive' directories and completely cleaned out 'dist'
  • fixed a bug with specHelper which was causing one of the old tests to fail
  • fix the benchmark page Performance page not working #364

```
cd some_project_directory
mkdir dustjs
git clone ... dustjs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may as well give a real URL here. Probably just give the http version. Also, I don't think you need to make a new directory. I think git clone will do that for you.

@jimmyhchan
Copy link
Contributor Author

In order to get Travis to pass we need to drop support for Node 0.6. The node world and grunt seem to only test 0.8 and 0.10

@rragan
Copy link
Contributor

rragan commented Dec 5, 2013

+1 drop 0.6

Rich
Sent from my iPhone

On Dec 4, 2013, at 4:05 PM, "jimmyhchan" <notifications@github.commailto:notifications@github.com> wrote:

In order to get Travis to pass we need to drop support for Node 0.6. The node world and grunt seem to only test 0.8 and 0.10


Reply to this email directly or view it on GitHubhttps://github.com//pull/371#issuecomment-29859345.

message: ['OK. Done bumping, adding, committing, and tagging the new version',
'',
'You still need to manually do the following:',
' * git push',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why can't these 3 commands be part of this release command?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand.
Grunt sets up a bunch tasks and then alias on line 213~222
These are all logging tasks. I want to call log when i'm done with the task.

@prashn64
Copy link
Contributor

prashn64 commented Dec 5, 2013

Pull in again and remove dist/dust-*-2.2.3.js

Otherwise, looks pretty good.

@jimmyhchan
Copy link
Contributor Author

merging from upstream master

@prashn64
Copy link
Contributor

prashn64 commented Dec 6, 2013

Pull in again, and we should be good to go.

prashn64 added a commit that referenced this pull request Dec 7, 2013
Fix our release process + add bower.json + jshint + cleanup master
@prashn64 prashn64 merged commit 931083b into linkedin:master Dec 7, 2013
@jimmyhchan jimmyhchan deleted the grunt branch December 7, 2013 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants