-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix our release process + add bower.json + jshint + cleanup master #371
Conversation
…to be a UMD module and play nicely with require
…ing them on the fly
…so it pulls down only what it needs
…build full version does not work as a node module it is only usable on the browser. Give that to bower
``` | ||
cd some_project_directory | ||
mkdir dustjs | ||
git clone ... dustjs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may as well give a real URL here. Probably just give the http version. Also, I don't think you need to make a new directory. I think git clone will do that for you.
… has an issue with node 0.6
In order to get Travis to pass we need to drop support for Node 0.6. The node world and grunt seem to only test 0.8 and 0.10 |
+1 drop 0.6 Rich On Dec 4, 2013, at 4:05 PM, "jimmyhchan" <notifications@github.commailto:notifications@github.com> wrote: In order to get Travis to pass we need to drop support for Node 0.6. The node world and grunt seem to only test 0.8 and 0.10 — |
…y nice with bower.json. allow archives to be pushed to github. bower does not need to know about grunt as a dev depedency
message: ['OK. Done bumping, adding, committing, and tagging the new version', | ||
'', | ||
'You still need to manually do the following:', | ||
' * git push', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why can't these 3 commands be part of this release command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand.
Grunt sets up a bunch tasks and then alias on line 213~222
These are all logging tasks. I want to call log when i'm done with the task.
Pull in again and remove dist/dust-*-2.2.3.js Otherwise, looks pretty good. |
merging from upstream master |
Pull in again, and we should be good to go. |
Fix our release process + add bower.json + jshint + cleanup master
For issues #361, #365, #366, #369, #364
List of changes
make
togrunt
grunt-release
. Now it's a one step process with compressed zip/tarballs autogenerated.cover
toistanbul