Django fixes #515
Merged
Django fixes #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer django versions do not use pytz by default, so we can remove the dependency here, and rely on Django's timezone methods.
Since the browser may post naive timestamps, we need to ensure that our times are properly handled. We want to active the timezone from our setting, and then use make_aware for our naive times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #495 ( 06a2c20 ) we upgraded Django. This means that Django itself doesn't depend on pytz, but we still had a few instances of our code requiring it. Instead of making pytz a dependency of Promgen, we can refactor a few bits to remove the dependency.