Upgrade to Django 4.2 #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Django 3.2 is past EOL and 4.2 is the current LTS version. There are not many changes that seem to directly affect us, and we can simply run the third-party django-upgrade command to take care of a few minor updates.
Some of the behavior for related fields changed in 4.2, so we fix our test case to reload from the database to avoid triggering this edge case.
Currently our rule test triggers an edge case in Django 4.2's more strict handling of related fields. We'll temporarily disable these tests since we're planning on rewriting the entire import function anyways.
vincent-olivert-riera
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django 3.2 is past EOL ( https://endoflife.date/django ) and 4.2 is the current LTS version. There are not many changes that seem to directly affect us, and we can simply run the third-party django-upgrade command to take care of a few minor updates.